feat(core): Add the dataCollection.queues option - #24087
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
s1gr1d
marked this pull request as ready for review
September 4, 2026 12:12
s1gr1d
requested review from
JPeer264,
andreiborza,
msonnb and
stephanie-anderson
and removed request for
a team,
JPeer264 and
stephanie-anderson
September 4, 2026 12:12
Contributor
size-limit report 📦
|
msonnb
approved these changes
Sep 4, 2026
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data collection spec added a
queuesoption in 0.7.0 and we never picked it up, sodataCollection.queueswas silently ignored.Added it with the documented default of
true. The only queue payload the SDK collects today is the Kafka message key, which producers often fill with a user or tenant id, so that is what the option gates. Topic, partition and offset stay put. They are structural metadata.Fixes #24082