feat(server-utils): Emit low cardinality function.gcp span names for firebase functions - #24069
Open
Lms24 wants to merge 1 commit into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8ca1bf7. Configure here.
Contributor
size-limit report 📦
|
Lms24
marked this pull request as ready for review
September 4, 2026 09:41
Lms24
requested review from
andreiborza,
msonnb and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
September 4, 2026 09:41
Lms24
force-pushed
the
lms/feat-server-utils-firebase-span-names
branch
from
September 4, 2026 11:11
8ca1bf7 to
6994af6
Compare
andreiborza
approved these changes
Sep 4, 2026
…r firebase functions Firebase function spans were named `firebase.function.<triggerType>`, which does not follow the FaaS span name convention. With span streaming enabled they are now named after the function, falling back to `Serverless function execution` when neither `FUNCTION_TARGET` nor `K_SERVICE` resolves. Static mode keeps the previous name. `faas.name` no longer falls back to the literal string `unknown`, so that an unresolvable name produces the static fallback rather than a span named `unknown`. The former span name is kept on `gcp.function.context.type` so the span description can still be derived from it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/feat-server-utils-firebase-span-names
branch
from
September 4, 2026 12:11
6994af6 to
086aa7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts
function.gcpspans for firebase functions:gcp.function.context.typeattributes to ensure seamless static->streaming migrations for span decriptions.