Skip to content

test(e2e): Restore scope isolation coverage on spans under span streaming - #24055

Merged
chargome merged 1 commit into
developfrom
fix-scope-isolation-spans
Sep 4, 2026
Merged

test(e2e): Restore scope isolation coverage on spans under span streaming#24055
chargome merged 1 commit into
developfrom
fix-scope-isolation-spans

Conversation

@chargome

@chargome chargome commented Sep 4, 2026

Copy link
Copy Markdown
Member

Restores the isolation-scope assertions the span streaming port dropped from the Next.js 16 middleware specs by having the test apps report isolation state as span attributes instead of scope tags.

Fixes #23941

…ming

The span streaming port dropped the isolation-scope assertions on the Next.js 16
middleware specs because streamed spans carry no scope tags. The test apps now report
the isolation state as span attributes, and the nextjs-16 route handler behind the proxy
does the same so the leak guard for vercel/next.js#95306 is back.

Fixes #23941
Refs JS-3534
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@chargome chargome self-assigned this Sep 4, 2026
@chargome

chargome commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 4c8e80a. Configure here.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28.69 kB added added
@sentry/browser - with treeshaking flags 26.99 kB added added
@sentry/browser - with treeshaking flags tracing without tracing 26.89 kB added added
@sentry/browser (incl. Tracing) 49.07 kB added added
@sentry/browser (incl. Tracing + Span Streaming) 49.07 kB added added
@sentry/browser (incl. Tracing, Profiling) 51.98 kB added added
@sentry/browser (incl. Tracing, Replay) 88.55 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.85 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 93.24 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 106.18 kB added added
@sentry/browser (incl. Feedback) 46.17 kB added added
@sentry/browser (incl. sendFeedback) 33.75 kB added added
@sentry/browser (incl. FeedbackAsync) 38.85 kB added added
@sentry/browser (incl. Metrics) 29.66 kB added added
@sentry/browser (incl. Logs) 29.94 kB added added
@sentry/browser (incl. Metrics & Logs) 30.59 kB added added
@sentry/react 30.45 kB added added
@sentry/react (incl. Tracing) 51.28 kB added added
@sentry/vue 35.91 kB added added
@sentry/vue (incl. Tracing) 51.34 kB added added
@sentry/svelte 28.71 kB added added
CDN Bundle 30.43 kB added added
CDN Bundle (incl. Tracing) 49.6 kB added added
CDN Bundle (incl. Logs, Metrics) 32.66 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) 51.53 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) 73.25 kB added added
CDN Bundle (incl. Tracing, Replay) 87.1 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.97 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 93.03 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.97 kB added added
CDN Bundle - uncompressed 90.13 kB added added
CDN Bundle (incl. Tracing) - uncompressed 147.81 kB added added
CDN Bundle (incl. Logs, Metrics) - uncompressed 96.52 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 153.59 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 225.68 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 267.3 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 273.07 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 281 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 286.76 kB added added
@sentry/nextjs (client) 53.89 kB added added
@sentry/sveltekit (client) 49.51 kB added added
@sentry/core/server 40.96 kB added added
@sentry/core/browser 13.53 kB added added
@sentry/node 124.66 kB added added
@sentry/node/import (ESM hook with diagnostics-channel injection) 81.51 kB added added
@sentry/node - without tracing 88.5 kB added added
@sentry/node - without channel injection 103.95 kB added added
@sentry/aws-serverless 96.87 kB added added
@sentry/cloudflare (withSentry) - minified 201.56 kB added added
@sentry/cloudflare (withSentry) 501.37 kB added added

View base workflow run

@chargome
chargome marked this pull request as ready for review September 4, 2026 07:21
@chargome
chargome merged commit 7cd3590 into develop Sep 4, 2026
51 checks passed
@chargome
chargome deleted the fix-scope-isolation-spans branch September 4, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E: restore scope isolation coverage on spans under span streaming

2 participants