Skip to content

test(node): Assert absence of PII attributes in OpenAI integration tests #24031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itz-puneet wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

test(node): Assert absence of PII attributes in OpenAI integration tests #24031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions dev-packages/node-integration-tests/suites/tracing/openai/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,16 @@ describe('OpenAI integration', () => {
type: 'string',
value: 'auto.ai.openai',
});

// PII attributes must never be recorded when `sendDefaultPii` is disabled.
// Asserting over every span in the envelope catches attributes leaking onto
// spans which are not individually inspected above.
for (const span of container.items) {
expect(span.attributes[GEN_AI_INPUT_MESSAGES]).toBeUndefined();
expect(span.attributes[GEN_AI_SYSTEM_INSTRUCTIONS]).toBeUndefined();
expect(span.attributes[GEN_AI_RESPONSE_TEXT]).toBeUndefined();
expect(span.attributes[GEN_AI_EMBEDDINGS_INPUT]).toBeUndefined();
}
},
})
.start()
Expand Down Expand Up @@ -845,6 +855,16 @@ describe('OpenAI integration', () => {
type: 'integer',
value: 10,
});

// PII attributes must never be recorded when `sendDefaultPii` is disabled.
// Asserting over every span in the envelope catches attributes leaking onto
// spans which are not individually inspected above.
for (const span of container.items) {
expect(span.attributes[GEN_AI_INPUT_MESSAGES]).toBeUndefined();
expect(span.attributes[GEN_AI_SYSTEM_INSTRUCTIONS]).toBeUndefined();
expect(span.attributes[GEN_AI_RESPONSE_TEXT]).toBeUndefined();
expect(span.attributes[GEN_AI_EMBEDDINGS_INPUT]).toBeUndefined();
}
},
})
.start()
Expand Down