fix(v10/nuxt): Detect Nitro version via the app's Nuxt dependency chain - #24025
Open
s1gr1d wants to merge 1 commit into
Open
fix(v10/nuxt): Detect Nitro version via the app's Nuxt dependency chain#24025s1gr1d wants to merge 1 commit into
s1gr1d wants to merge 1 commit into
Conversation
…24019) In a monorepo where a `nitro` v3 package is resolvable above a Nitro-v2 Nuxt app, the SDK registers the Nitro v3 plugin variants and the app silently loses storage, database, and cache instrumentation. Nitro v2 is published as `nitropack`, v3 as `nitro`. `getNitroMajorVersion()` asked local-pkg for any package named `nitro` with no anchor. Module resolution walks up the directory tree, so an unrelated `nitro` v3 higher up (for example a workspace-root devDependency) wins even though the app's Nuxt imports `nitropack` v2. The fix follows the dependency chain Nuxt itself imports Nitro through: resolve `nuxt` from `rootDir`, hop to `@nuxt/nitro-server` when nuxt declares it (Nuxt >= 3.21), and only resolve `nitro` if that provider declares it. `nitropack` instead means v2: - Nuxt 3.x / 4.0–4.1: `nuxt` → `nitropack@2` - Nuxt ≥4.2 stable: `nuxt` → `@nuxt/nitro-server` → `nitropack@2` - Nuxt 5 nightly: `nuxt` → `@nuxt/nitro-server`(-nightly) → `nitro@3`
s1gr1d
requested review from
chargome and
mydea
and removed request for
a team
September 3, 2026 15:39
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24019