docs(react): Add JSDoc to withSentryRouting - #24012
Merged
Merged
Conversation
The HOC is the only routing wrapper in the package without a doc comment, so nothing tells users it targets React Router v4/v5 only, that the wrapped Route must be rendered inside a Switch, or that v6+ should use wrapReactRouterRouting. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MQRr9S6B2FYBKa9bMWHSxk
Contributor
size-limit report 📦
|
chargome
marked this pull request as ready for review
September 3, 2026 12:50
chargome
requested review from
mydea and
s1gr1d
and removed request for
a team
September 3, 2026 12:50
Member
|
Maybe we can think about, for v12 or whenever, to split these into a |
mydea
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents that
withSentryRoutingtargets React Router v4/v5 only, needs the wrappedRouterendered inside aSwitch, and that v6+ users should reach forwrapReactRouterRoutinginstead.