fix(browser)!: stop tagging DOMException.code on events - #23992
Merged
Conversation
RealBhupesh
requested review from
Lms24 and
msonnb
and removed request for
a team
September 3, 2026 10:05
msonnb
changed the title
Lms24
approved these changes
Sep 3, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
Good cleanup, thanks!
side-note: If by popular demand, we should bring back the code, we should do so as a context, not as a tag, as suggested in #10501 (comment). IMHO it's fine to remove this, given the age and the replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DOMException.codeas an event tagDOMException.nameremains available viaerror.typeon the exception payloadFixes #10501
Test plan
packages/browser/test/eventbuilder.test.ts