feat(remix): Auto-wire orchestrion build-time instrumentation - #23988
Merged
Conversation
Member
Author
|
bugbot run |
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
`sentryRemixVitePlugin()` now adds the orchestrion bundler plugin automatically, so bundled SSR builds get `diagnostics_channel` publishers injected with no manual plugin setup. Remix was the last metaframework SDK still requiring users to wire `sentryOrchestrionPlugin()` themselves. Builds targeting workerd (Cloudflare Pages, Hydrogen/Oxygen) are skipped: they instrument through `instrumentBuild()` from `@sentry/remix/cloudflare` and never subscribe to the injected channels. Fixes #23986 Refs #22632 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0189LWkpCsFqEwM5EFoT11TJ
chargome
force-pushed
the
remix-orchestrion-support
branch
from
September 3, 2026 09:22
b6725c7 to
e070d45
Compare
chargome
changed the title
Member
Author
|
bugbot run |
Remix's own Vite plugin never sets `ssr.target`, so checking it alone missed Cloudflare Pages apps: `cloudflareDevProxyVitePlugin` marks the runtime with `ssr.resolve.externalConditions` and the Cloudflare template sets `ssr.resolve.conditions`. Those builds would have had `node:diagnostics_channel` injected into a bundle workerd cannot load. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0189LWkpCsFqEwM5EFoT11TJ
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 45154a7. Configure here.
chargome
marked this pull request as ready for review
September 3, 2026 11:20
chargome
requested review from
andreiborza,
isaacs,
mydea and
s1gr1d
and removed request for
a team
September 3, 2026 11:20
s1gr1d
approved these changes
Sep 3, 2026
chargome
added a commit
that referenced
this pull request
Sep 3, 2026
- `sentryRemixVitePlugin` moves from the main `@sentry/remix` entry to a dedicated `@sentry/remix/vite` subpath, matching `@sentry/sveltekit` and `@sentry/react-router`. - It was exported from `index.server.ts`, the package's CJS `main`, so anything the plugin imports lands in the module graph of every Remix server process. Splitting the entry keeps build-time-only dependencies off the runtime path. - It now returns an array so further plugins can be added without another breaking change — #23988 stacks on this to auto-wire the orchestrion transform. Refs #23986 Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentryRemixVitePlugin()now applies the orchestrion bundler transform automatically. Remix was the last metaframework SDK still asking users to addsentryOrchestrionPlugin()themselves.instrumentBuild()from@sentry/remix/cloudflare, so the injected channels would be dead code in a worker bundle.serveso deps stay external for the runtime--importhook.Fixes #23986
Refs #22632