test(e2e): Port the angular-21 E2E app to span streaming - #23984
Merged
Conversation
Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Contributor
size-limit report 📦
|
RulaKhaled
marked this pull request as ready for review
September 3, 2026 10:30
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Lms24
approved these changes
Sep 3, 2026
Comment on lines
+157
to
+158
| // The routing span starts at NavigationStart with only the raw URL, so under streaming it is named Router. | ||
| expect(routingSpan?.name).toBe('Router'); |
Member
There was a problem hiding this comment.
hmm this is interesting. Wondering if we can do better here and actually update the routing span name later on. Out of scope for this PR though, ignore me 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports
angular-21to span streaming: thetraceLifecycle: 'static'pin is removed and the specs assert on streamed spans.Why
Span streaming is the default, so the default E2E suite should exercise it. Angular
routerspans are namedRouterbecause they start atNavigationStartwith only the raw URL. Pageload and navigation segments still get the parameterized route fromResolveEnd. Cancelled and failed navigations never hitResolveEnd, so those segments keep theNavigationfallback and are matched onurl.path.Did not add an
angular-20-staticcopy.angular-19already runs the full transaction suite on the default (static) build and a streamed variant viasentryTest.variants, so a sixth Angular e2e app would only duplicate that coverage.Part of #23811