fix(nextjs): Add orchestrion bundling regression tests and import.meta.url shim - #23935
Merged
Conversation
s1gr1d
requested review from
chargome,
mydea and
nicohrubec
and removed request for
a team and
nicohrubec
September 2, 2026 12:19
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
s1gr1d
marked this pull request as draft
September 2, 2026 12:25
Contributor
size-limit report 📦
|
s1gr1d
changed the title
s1gr1d
marked this pull request as ready for review
September 2, 2026 12:42
mydea
reviewed
Sep 3, 2026
| ); | ||
| expect(serverFiles.length).toBeGreaterThan(0); | ||
|
|
||
| const markers = ['code-transformer-bundler-plugins', '__codeTransformerWebpackDiagnostics']; |
Member
There was a problem hiding this comment.
l: did we verify this still is the same here on v11? Just do make sure, because we changed a bunch of stuff around these I believe.
Member
Author
There was a problem hiding this comment.
Verified on v11: both are still in the build output.
code-transformer-bundler-pluginsis the vendored directory name and appears in the require paths insidebuild/cjs/orchestrion/bundler/webpack.js- and
__codeTransformerWebpackDiagnosticsis still in the vendored webpack plugin
But I'm going to add a check to make sure this fails when this is renamed.
chargome
approved these changes
Sep 3, 2026
|
Are there any plans to backport this to v10? |
Member
Author
|
This is already available on the v10 branch and comes with the next release. The two PRs are also linked in the description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just adding the tests of the v10 PRs to make sure we don't have a regression.
Ported tests of two v10 PRs:
One test caught a real problem: the
@sentry/server-utilsCJS build still replacedimport.meta.urlwith a snippet that assumes "adocumentglobal means a browser", crashing under jsdom.The v10 lazy-loading fix needs no porting: on v11,
withSentryConfiglives in the separate@sentry/nextjs/configexport, so importing the SDK never reaches the bundler plugins.Fixes #23789