Skip to content

fix(repo): Align nx cache outputs with actual build outputs #23929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 3 commits into from
Sep 2, 2026
Merged

fix(repo): Align nx cache outputs with actual build outputs #23929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00afc28
fix(repo): Align nx cache outputs with actual build outputs
mydea Sep 2, 2026
59817ba
fix(repo): Make deno build:transpile and build:types cache outputs di…
mydea Sep 2, 2026
f5b52aa
fix(repo): Skip negated Nx outputs in ci-print-build-artifact-paths
mydea Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/astro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,5 +88,18 @@
},
"astro": {
"external": true
},
"nx": {
"targets": {
"build:transpile": {
"outputs": [
"{projectRoot}/build/esm",
"{projectRoot}/build/cjs",
"{projectRoot}/build/npm/esm",
"{projectRoot}/build/npm/cjs",
"{projectRoot}/build/import-hook.mjs"
]
}
}

@cursor cursor Bot Sep 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PR missing regression test

Low Severity

This fix PR has no test that would fail if an nx outputs list again missed a file the build emits. The review guidelines for fix PRs require a regression test, which is what let these cache lists drift in the first place.

Additional Locations (2)
Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 00afc28. Configure here.

}
}
3 changes: 2 additions & 1 deletion packages/aws-serverless/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@
"{projectRoot}/build/npm/cjs",
"{projectRoot}/build/npm/run-lambda-handler.mjs",
"{projectRoot}/build/npm/run-lambda-handler.mjs.map",
"{projectRoot}/build/lambda-extension"
"{projectRoot}/build/lambda-extension",
"{projectRoot}/build/import-hook.mjs"
],
"cache": true
},
Expand Down
5 changes: 3 additions & 2 deletions packages/deno/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,13 @@
"targets": {
"build:transpile": {
"outputs": [
"{projectRoot}/build"
"{projectRoot}/build",
"!{projectRoot}/build/esm/**/*.d.ts"
]
},
"build:types": {
"outputs": [
"{projectRoot}/build-types"
"{projectRoot}/build/esm/**/*.d.ts"
Comment thread
cursor[bot] marked this conversation as resolved.
]
}
}
Expand Down
15 changes: 14 additions & 1 deletion packages/google-cloud-serverless/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,5 +79,18 @@
"volta": {
"extends": "../../package.json"
},
"sideEffects": false
"sideEffects": false,
"nx": {
"targets": {
"build:transpile": {
"outputs": [
"{projectRoot}/build/esm",
"{projectRoot}/build/cjs",
"{projectRoot}/build/npm/esm",
"{projectRoot}/build/npm/cjs",
"{projectRoot}/build/import-hook.mjs"
]
}
}
}
}
3 changes: 2 additions & 1 deletion packages/nestjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@
],
"outputs": [
"{projectRoot}/build/types",
"{projectRoot}/*.d.ts"
"{projectRoot}/*.d.ts",
"{projectRoot}/*.d.ts.map"
],
"cache": true
}
Expand Down
15 changes: 14 additions & 1 deletion packages/remix/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,5 +100,18 @@
"volta": {
"extends": "../../package.json"
},
"sideEffects": false
"sideEffects": false,
"nx": {
"targets": {
"build:transpile": {
"outputs": [
"{projectRoot}/build/esm",
"{projectRoot}/build/cjs",
"{projectRoot}/build/npm/esm",
"{projectRoot}/build/npm/cjs",
"{projectRoot}/build/import-hook.mjs"
]
}
}
}
}
15 changes: 14 additions & 1 deletion packages/tanstackstart-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,5 +87,18 @@
"volta": {
"extends": "../../package.json"
},
"sideEffects": false
"sideEffects": false,
"nx": {
"targets": {
"build:transpile": {
"outputs": [
"{projectRoot}/build/esm",
"{projectRoot}/build/cjs",
"{projectRoot}/build/npm/esm",
"{projectRoot}/build/npm/cjs",
"{projectRoot}/build/import-hook.mjs"
]
}
}
}
}
13 changes: 12 additions & 1 deletion packages/vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,5 +89,16 @@
"volta": {
"extends": "../../package.json"
},
"sideEffects": false
"sideEffects": false,
"nx": {
"targets": {
"build:types": {
"outputs": [
"{projectRoot}/build/types",
"{projectRoot}/*.d.ts",
"{projectRoot}/*.d.ts.map"
]
}
}
}
}
6 changes: 6 additions & 0 deletions scripts/ci-print-build-artifact-paths.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ for (const node of Object.values(graph.nodes)) {
}

for (const output of outputs) {
// Negated outputs only narrow a target's Nx cache ownership to keep parallel targets'
// outputs disjoint; they are not files to exclude from the uploaded artifact — those files
// are emitted and owned by another target and must still be uploaded via its output.
if (output.startsWith('!')) {
continue;
}
const rel = output.replace(/\{projectRoot\}/g, root).replace(/\\/g, '/');
const prefix = `${kind}/${pkg}/`;
if (!rel.startsWith(prefix)) {
Expand Down
Loading