feat(core): Record callback_error client reports for throwing user callbacks - #23903
Open
msonnb wants to merge 1 commit into
Open
feat(core): Record callback_error client reports for throwing user callbacks#23903msonnb wants to merge 1 commit into
callback_error client reports for throwing user callbacks#23903msonnb wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
msonnb
force-pushed
the
ms/callback-error-drop-reason
branch
from
September 3, 2026 09:16
d9e33fd to
dd74588
Compare
…callbacks Events, logs, metrics and root spans dropped because a user callback threw were reported with the same outcome as a legitimate filter (`before_send`, `event_processor`, `sample_rate`). A dedicated `callback_error` reason makes them distinguishable. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
msonnb
force-pushed
the
ms/callback-error-drop-reason
branch
from
September 3, 2026 09:42
dd74588 to
8f068cc
Compare
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8f068cc. Configure here.
msonnb
marked this pull request as ready for review
September 3, 2026 12:11
msonnb
requested review from
Lms24,
isaacs and
mydea
and removed request for
a team
September 3, 2026 12:11
Lms24
reviewed
Sep 3, 2026
| samplingContext: SamplingContext, | ||
| sampleRand: number, | ||
| ): [sampled: boolean, sampleRate?: number, localSampleRateWasApplied?: boolean] { | ||
| ): SamplingDecision { |
Member
There was a problem hiding this comment.
m: this is API breaking, since sampleSpan is exported. I agree that the object is easier to read though . IIRC, we used the named tuple here for bundle size minimization but this is less readable than the refactor.
Breaking here isn't a big deal though, so we can also do it if the tuple no longer works. But if we do, let's add a note in the migration guide.
| () => processor({ ...event }, hint), | ||
| () => null, | ||
| () => { | ||
| throw CALLBACK_ERROR; |
Member
There was a problem hiding this comment.
m: throwing here and in client.ts made me a bit suspicious because we have to be really careful to also catch our throws. Looks like there's a case in replay where we also call prepareEvent which doesn't try/catch the call. I think this only concerns event processor throws though. This leads to us trying to re-send the replay because we assume a network error. Ultimately, we stop recording.
I think we have two options how to avoid this:
- we try/catch in Replay so that this doesn't happen
- we don't throw at all. Instead, we could directly record an dropped event in
notifyEventProcessorsand distinguish there.
Tbqh: I haven't thought this through end-to-end, so maybe 1 is easier. I don't see us reusing prepareEvent much in the foreseeable future. But happy to let you make the call (also feel free to come up with something else).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops caused by a throwing user callback were reported with the same client report reason as a legitimate filter. They now use a new
callback_errorreason so the two are distinguishable.Part of #23755