test(e2e): Port React Router SPA E2E apps to span streaming - #23843
Merged
Conversation
Contributor
size-limit report 📦
|
andreiborza
force-pushed
the
ab/js-3482/spa-apps
branch
from
September 1, 2026 14:21
19aca83 to
7d5db09
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7d5db09. Configure here.
andreiborza
force-pushed
the
ab/js-3482/spa-apps
branch
from
September 1, 2026 14:56
7d5db09 to
d50ce36
Compare
andreiborza
force-pushed
the
ab/js-3482/data-routers
branch
from
September 1, 2026 14:56
450d0d3 to
361c467
Compare
andreiborza
marked this pull request as ready for review
September 1, 2026 15:28
chargome
approved these changes
Sep 1, 2026
andreiborza
force-pushed
the
ab/js-3482/data-routers
branch
from
September 1, 2026 16:51
361c467 to
a0463ab
Compare
andreiborza
force-pushed
the
ab/js-3482/spa-apps
branch
2 times, most recently
from
September 2, 2026 08:23
b03837a to
d33d48c
Compare
andreiborza
force-pushed
the
ab/js-3482/data-routers
branch
from
September 2, 2026 08:23
a0463ab to
035ea0c
Compare
andreiborza
force-pushed
the
ab/js-3482/spa-apps
branch
from
September 2, 2026 08:46
d33d48c to
8870eb6
Compare
andreiborza
force-pushed
the
ab/js-3482/data-routers
branch
2 times, most recently
from
September 2, 2026 09:05
10e5c15 to
d2e75d6
Compare
andreiborza
force-pushed
the
ab/js-3482/spa-apps
branch
from
September 2, 2026 09:05
8870eb6 to
2ed771f
Compare
andreiborza
force-pushed
the
ab/js-3482/data-routers
branch
from
September 2, 2026 09:30
d2e75d6 to
b6f6642
Compare
andreiborza
force-pushed
the
ab/js-3482/spa-apps
branch
from
September 2, 2026 09:30
2ed771f to
7e3b354
Compare
andreiborza
force-pushed
the
ab/js-3482/data-routers
branch
from
September 2, 2026 10:01
b6f6642 to
4f8a0f4
Compare
andreiborza
force-pushed
the
ab/js-3482/spa-apps
branch
from
September 2, 2026 10:01
7e3b354 to
638598a
Compare
Removes the `traceLifecycle: 'static'` pin from `react-router-7-spa`, `react-router-8-spa`, `react-router-7-cross-usage`, `react-router-8-cross-usage` and `react-router-8-cloudflare`, and rewrites their specs against streamed span v2. The Cloudflare mysql spec matches on `db.query.text` now: under streaming a mysql span is named after its query summary, so both queries in that route are called `SELECT`.
andreiborza
force-pushed
the
ab/js-3482/data-routers
branch
from
September 2, 2026 10:07
4f8a0f4 to
a3cd640
Compare
andreiborza
force-pushed
the
ab/js-3482/spa-apps
branch
from
September 2, 2026 10:07
638598a to
5b28e50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports
react-router-7-spa,react-router-8-spa,react-router-7-cross-usage,react-router-8-cross-usageandreact-router-8-cloudflareto span streaming.Why
Span streaming is the default now, so the E2E suite has to exercise it. The Cloudflare mysql spec matches on
db.query.text, because a streamed mysql span is named after its query summary and both queries in that route come out asSELECT.Part of #23798