feat(core): Add safeCallback helper for isolating user-provided callbacks - #23760
Merged
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
msonnb
changed the title
safeCallback helper for isolating user-provided callbackssafeCallback helper for isolating user-provided callbacks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit bb9a102. Configure here.
mydea
reviewed
Sep 1, 2026
| return modifiedSpan; | ||
| } | ||
|
|
||
| if (!hasShownSpanDropWarning) { |
Member
There was a problem hiding this comment.
unrelated to this PR, but we can possibly remove this warning (safe some bytes), this has been this way for some time 🤔 or at least make it a debug.warn gated by the debug flag so you can shake it out?
Member
Author
There was a problem hiding this comment.
yeah i think we can remove it tbh. has been like this since v9 and the type doesn't allow it anyway.
msonnb
force-pushed
the
ms/safe-callback-helper
branch
from
September 1, 2026 12:17
bb9a102 to
9792842
Compare
msonnb
marked this pull request as ready for review
September 1, 2026 12:20
msonnb
requested review from
Lms24,
logaretm and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
September 1, 2026 12:20
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9792842. Configure here.
Lms24
approved these changes
Sep 1, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
Had one follow-up suggestion for better tree-shaking but otherwise looks good!
| } | ||
|
|
||
| function recover<T>(message: string, error: unknown, fallback: (error: unknown) => T): T { | ||
| DEBUG_BUILD && debug.error(message, error); |
Member
There was a problem hiding this comment.
I think the flag is correct here but the bot review is right: We no longer tree-shake out the actual string passed to this function if DEBUG_BUILD is false. We can still add a ternary to the call-sitest to enable tree shaking, something like
safeCallback(DEBUG_BUILD ? 'full warning/error message' : '', () => {}, () => {})
…backs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
msonnb
force-pushed
the
ms/safe-callback-helper
branch
from
September 1, 2026 12:42
9792842 to
e3f5c00
Compare
msonnb
added a commit
that referenced
this pull request
Sep 3, 2026
… as events (#23770) Wraps `beforeSend`, `beforeSendTransaction`, event processors, `tracesSampler`, `beforeBreadcrumb`, `beforeSendLog` and `beforeSendMetric` in the `safeCallback` helper from #23760. A throwing or rejecting callback no longer escapes into the calling code and is no longer captured as an `internal` error event; the event/breadcrumb/log/metric is dropped, a client report is recorded where a category exists, and the error is logged in debug mode. part of #23755 --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
safeCallback(message, fn, fallback)helper which runs a user-provided callback, and on a sync throw or async rejection logsmessageviadebug.errorand returnsfallback(error)instead of propagating.applyBeforeSendSpanCallbackand the undicisafeExecuteare refactored onto the helper so there is a single implementation.First step of #23755, next PR will wrap the rest of the user-defined callbacks.