feat(v10/cloudflare): Derive rpcTracePropagationBindings from the wrangler config - #23738
Merged
JPeer264 merged 4 commits intoAug 28, 2026
Conversation
…ngler config Backport of: #23491
…ve-rpc-bindings-from-wrangler
JPeer264
marked this pull request as ready for review
August 28, 2026 13:26
JPeer264
requested review from
andreiborza,
isaacs and
nicohrubec
and removed request for
a team
August 28, 2026 13:26
Contributor
size-limit report 📦
|
…ve-rpc-bindings-from-wrangler
wrangler 4.x needs Node 20+, and v10 still runs unit tests on Node 18.
nicohrubec
approved these changes
Aug 28, 2026
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #23491
Differences to the original PR
packages/cloudflare/src/vite/transform.ts: the generated options callback also setsenableRpcTracePropagation: opts?.enableRpcTracePropagation ?? true. On v10 the receiver still reads that option to continue an incoming trace, and the plugin wrapped those receiver classes itself, so it can turn it on. An explicit value in the user's options wins. Without it the derived bindings would propagate but no receiver span would be created.packages/cloudflare/src/vite/index.tsand the new integration suite'svite.config.mts:autoInstrumentationlives under_experimentalon v10, so the doc paragraph and the test config use that shape.