ref(core)!: Remove supportsNativeFetch export - #23719
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
mydea
force-pushed
the
fn/remove-supports-native-fetch
branch
from
August 28, 2026 08:50
4bf8c35 to
4a25c19
Compare
mydea
marked this pull request as ready for review
August 28, 2026 09:09
mydea
requested review from
logaretm and
msonnb
and removed request for
a team
August 28, 2026 09:09
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
mydea
force-pushed
the
fn/remove-supports-native-fetch
branch
from
August 28, 2026 09:34
4a25c19 to
1c482b3
Compare
Comment on lines
15
to
19
|
|
||
| export { spanStreamingIntegration } from './integrations/browserSpanStreaming'; | ||
|
|
||
| export { supportsNativeFetch } from './utils/supports'; | ||
| export type { XhrBreadcrumbData, XhrBreadcrumbHint } from './types/breadcrumb'; | ||
| export type { BrowserClientReplayOptions } from './types/browseroptions'; |
Contributor
There was a problem hiding this comment.
Bug: The removal of supportsNativeFetch from public exports in @sentry/core/browser will break a test in httpclient.test.ts that spies on this function.
Severity: HIGH
Suggested Fix
Update the test in packages/browser/test/integrations/httpclient.test.ts. Either import supportsNativeFetch directly from its source file (../utils/supports) for mocking, or refactor the test to no longer depend on this removed public export.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/core/src/browser-exports.ts#L15-L19
Potential issue: The function `supportsNativeFetch` has been removed from the public
exports in `packages/core/src/browser-exports.ts`. However, the test file
`packages/browser/test/integrations/httpclient.test.ts` still imports it from
`@sentry/core/browser` and attempts to create a spy on it using `vi.spyOn(SentryCore,
'supportsNativeFetch')`. After this change, `SentryCore.supportsNativeFetch` will be
`undefined`, causing the spy to fail and breaking the test suite. While internal usage
is unaffected, the test represents a consumer of the public API that will now fail.
Also affects:
packages/browser/test/integrations/httpclient.test.ts
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1c482b3. Configure here.
|
|
||
| export { spanStreamingIntegration } from './integrations/browserSpanStreaming'; | ||
|
|
||
| export { supportsNativeFetch } from './utils/supports'; |
There was a problem hiding this comment.
Public API removed without deprecation
Medium Severity
This was flagged because the review rules call out removal of publicly exported functions without a deprecation notice. supportsNativeFetch was a public export from @sentry/core and @sentry/core/browser with no @hidden or @deprecated tag. Similar helpers such as supportsFetch stay exported as deprecated, and the v11 migration guide does not list this removal.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 1c482b3. Configure here.
mydea
force-pushed
the
fn/remove-supports-native-fetch
branch
from
August 28, 2026 09:53
1c482b3 to
8d5c407
Compare
msonnb
approved these changes
Aug 31, 2026
stack merge was automatically disabled
August 31, 2026 08:02
Pull Request is not mergeable
mydea
force-pushed
the
fn/remove-supports-native-fetch
branch
from
August 31, 2026 08:03
25b9834 to
afd4f14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes this export from core. It was only used by
HttpClientintegration to guard adding the fetch instrumentation, which should not be necessary (we do not do this for other places).