feat(server-runtime-injection): Split runtime orchestrion injection into a dedicated package - #23685
Open
mydea wants to merge 4 commits into
Open
feat(server-runtime-injection): Split runtime orchestrion injection into a dedicated package#23685mydea wants to merge 4 commits into
mydea wants to merge 4 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
August 27, 2026 14:28
mydea
force-pushed
the
split/server-runtime-injection
branch
from
August 28, 2026 09:27
c734727 to
24c382c
Compare
…nto a dedicated package The runtime diagnostics-channel injection (`register`/`hook`/`import-hook` + the vendored transformer chain meriyah/esquery/astring/source-map/tracing-hooks) must stay EXTERNAL when apps bundle their server, while the rest of `@sentry/server-utils` (barrel + config + bundler plugins) is meant to be bundled. Sharing one package made externalization fiddly. This moves the runtime injection into a new package, `@sentry/server-runtime-injection`, so "keep this external" is a clean package boundary. - New package holds `register`/`hook`/`import-hook` (subpaths `/register`, `/hook`, `/import-hook`) and vendors the transformer chain; it depends on `@sentry/server-utils` and imports `SENTRY_INSTRUMENTATIONS` from `./orchestrion/config` (config stays put). - `@sentry/server-utils` drops the runtime dir/exports and the runtime-only vendored deps; the lone `config/index.ts` bundler re-export moves to a new `./orchestrion/bundler-transforms` subpath so importing config stays transformer-free (bun updated). - References updated: node SDK + test mock, deno import, the shared `--import` template + `makeOrchestrionLoader` guard, Next.js externalization (`ORCHESTRION_RUNTIME_EXTERNAL_PACKAGES`, nextjs-anchored require-ability check, forwarder generation) + tests, `.size-limit.js`. - Dep added to runtime-injection consumers (node, nextjs, deno, aws/gcp-serverless, astro, tanstackstart-react); package registered in workspaces, `.craft.yml`, CODEOWNERS, aws e2e. Stacked on the detect/warn PR (#23675). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…-plugins dependency `@sentry/bun/plugin` now only re-exports from `@sentry/server-utils/orchestrion/bun` (which vendors the transformer), so the direct import is gone. Remove the leftover runtime dependency so installs don't pull an unused package. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
split/server-runtime-injection
branch
from
August 28, 2026 09:50
24c382c to
2a2a5e3
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2a2a5e3. Configure here.
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Feat PR lacks integration coverage
Low Severity
This is a feat PR that introduces @sentry/server-runtime-injection as a new package boundary, but it has no new integration or E2E test for the split. Existing unit tests and the aws-serverless packagesToLink update do not cover a bundled server keeping the new package external. Flagged because the review rules require a feat PR to include at least one integration or E2E test.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 2a2a5e3. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #23675 (the detect/warn work) — base this on
fix/orchestrion-detect-bundling; rebase ontodeveloponce #23675 merges.The runtime diagnostics-channel injection (
register/hook/import-hook+ the vendored transformer chain meriyah/esquery/astring/source-map/tracing-hooks) must stay external when apps bundle their server, while the rest of@sentry/server-utils(barrel + config + bundler plugins) is meant to be bundled. Sharing one package made externalization fiddly (Next.js forwarders, the vite plugin couldn't cleanly separate them). This moves the runtime injection into a new package,@sentry/server-runtime-injection, so "keep this external" is a clean package boundary.What moves / stays
@sentry/server-runtime-injection:register/hook/import-hook(clean subpaths/register,/hook,/import-hook) + the vendored transformer chain. It depends on@sentry/server-utilsand importsSENTRY_INSTRUMENTATIONSfrom./orchestrion/config— config stays put (pure data; resolves fromnode_modules, one-way dep, no cycle), so@sentry/server-utilsremains fully bundleable.@sentry/server-utils: drops the runtime dir/exports and the runtime-only vendored dep (@apm-js-collab/tracing-hooks); keeps the barrel + config + bundler plugins.@sentry/server-utilsas./orchestrion/bun, alongside the vite/rollup/webpack/esbuild plugins;@sentry/bun/pluginnow just re-exports it assentryBunPlugin. This letsconfig/index.tsdrop its bundler re-export (it only existed so@sentry/buncould compose the upstream plugin itself), keeping./orchestrion/configtransformer-free without needing a separatebundler-transformssubpath.References updated
sdk/index.ts+ test mock), Deno (import.mjs), the shared--importtemplate +makeOrchestrionLoaderguard (one source for every framework's generated hook).ORCHESTRION_RUNTIME_EXTERNAL_PACKAGES→ the new package; the require-ability check is re-anchored at@sentry/nextjs(so it works under pnpm, where a server-utils-anchored resolver couldn't see the new package); forwarder generation iterates the new package's exports; tests updated..size-limit.jshook path; the@sentry/server-runtime-injectiondep added to node/nextjs/deno/aws-serverless/google-cloud-serverless/astro/tanstackstart-react..craft.yml(base tier, after server-utils), CODEOWNERS, the aws-serverless e2epackagesToLink.Verification
New package builds (config external, transformer vendored, own THIRD-PARTY-LICENSES) and its tests pass;
server-utils(353),node(362),bun(50), and the Next.js config tests (122) pass; lint clean across all changed packages. Smoke-testedregisterin ESM + CJS (healthy → hooks install, no warning), the relocated bun plugin (banner + force-bundle instrumented deps), and confirmed the detection probe still fires on a tree-shaken bundle (warns once, exit 0). size-limit unchanged —@sentry/node119.79 kB, hook entry 79.78 kB, all pass.Follow-ups
@sentry/server-utilsdep fromgoogle-cloud-serverless(kept for safety).🤖 Generated with Claude Code