fix(wasm): Register modules loaded via non-streaming WebAssembly APIs - #23661
Draft
andreiborza wants to merge 2 commits into
Draft
fix(wasm): Register modules loaded via non-streaming WebAssembly APIs#23661andreiborza wants to merge 2 commits into
andreiborza wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
andreiborza
marked this pull request as ready for review
August 27, 2026 12:19
andreiborza
requested review from
logaretm and
msonnb
and removed request for
a team
August 27, 2026 12:19
andreiborza
force-pushed
the
ab/wasm-nonstreaming-registration
branch
from
August 27, 2026 12:19
b108f49 to
ccc54f1
Compare
andreiborza
marked this pull request as draft
August 27, 2026 12:50
andreiborza
force-pushed
the
ab/wasm-nonstreaming-registration
branch
from
August 27, 2026 14:01
ccc54f1 to
599115c
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 599115c. Configure here.
| * Looks up an image by URL in worker images. | ||
| */ | ||
| function getWorkerImage(url: string): number { | ||
| const workerImages = WINDOW._sentryWasmImages || []; |
There was a problem hiding this comment.
Missing fallback for unmatched WASM frames
Medium Severity
patchFrames still matches images only by exact code_file, but buffer-compiled modules at or below V8's 16383-byte cutoff are registered as wasm://wasm/unknown (or wasm://wasm/<name>-unknown) while engine frames use a real content hash. _fromBuffer is stored and stripped, yet never used, so those frames never get addr_mode or debug_meta. Firefox call-site names have the same gap.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 599115c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Registers WASM modules that are loaded through
WebAssembly.instantiate(buffer),WebAssembly.compile, andnew WebAssembly.Module()so their frames get symbolicated. Those modules carry no URL, so they are registered under the synthetic script name the engine reports in stack frames (wasm://wasm/<hash>), which V8 derives from the byte length for modules above 16383 bytes. Smaller modules get a placeholder name and are matched by elimination instead.Why
Non-streaming loads (the Emscripten fallback, dynamic linking, Godot Web) produced events without
debug_meta, so uploaded debug files were never applied.Closes: #19564