Skip to content

chore(deps-dev): Bump the react-router group to 8.3.0 - #23642

Closed
andreiborza wants to merge 2 commits into
developfrom
ab/bump-react-router-8
Closed

chore(deps-dev): Bump the react-router group to 8.3.0#23642
andreiborza wants to merge 2 commits into
developfrom
ab/bump-react-router-8

Conversation

@andreiborza

@andreiborza andreiborza commented Aug 26, 2026

Copy link
Copy Markdown
Member

What

Bumps the react-router dev dependency group in packages/react-router to 8.3.0, and stops the SDK from importing AppLoadContext, which react-router v8 removed. The load context of wrapSentryHandleRequest is now inferred, so v7 apps that extend AppLoadContext through declaration merging keep type checking.

Why

Supersedes #23260, which could not build against v8. Nothing changes for SDK users, because @react-router/dev is a devDependency only and the peer ranges are unchanged, but contributors now need --ignore-engines on a local yarn install, since @react-router/dev@8 wants Node >= 22.22.0 against the Volta pin of 20.19.5 (CI already passes that flag).

Supersedes #23260, which could not build because react-router v8 removed the
`AppLoadContext` export.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@andreiborza
andreiborza requested a review from chargome August 26, 2026 11:02
@andreiborza

Copy link
Copy Markdown
Member Author

Hermes ran the winding roads,
but v8 burned his context scrolls.
Athena typed the routes anew
and let inference guard the tolls.

Now Charon waits beside the diff,
an obol for a passing glance.
@chargome, lend this bump your eyes,
and ferry it across to develop.

@andreiborza
andreiborza marked this pull request as ready for review August 26, 2026 11:04
@andreiborza
andreiborza requested a review from a team as a code owner August 26, 2026 11:04
@andreiborza
andreiborza requested review from nicohrubec and removed request for a team August 26, 2026 11:04
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28.57 kB - -
@sentry/browser - with treeshaking flags 26.92 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 26.82 kB - -
@sentry/browser (incl. Tracing) 48.58 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.6 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.51 kB - -
@sentry/browser (incl. Tracing, Replay) 88.04 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.44 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 92.75 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 105.44 kB - -
@sentry/browser (incl. Feedback) 45.81 kB - -
@sentry/browser (incl. sendFeedback) 33.36 kB - -
@sentry/browser (incl. FeedbackAsync) 38.46 kB - -
@sentry/browser (incl. Metrics) 29.51 kB - -
@sentry/browser (incl. Logs) 29.8 kB - -
@sentry/browser (incl. Metrics & Logs) 30.43 kB - -
@sentry/react 30.31 kB - -
@sentry/react (incl. Tracing) 50.79 kB - -
@sentry/vue 35.69 kB - -
@sentry/vue (incl. Tracing) 50.82 kB - -
@sentry/svelte 28.59 kB - -
CDN Bundle 30.36 kB - -
CDN Bundle (incl. Tracing) 49.07 kB - -
CDN Bundle (incl. Logs, Metrics) 32.56 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 50.95 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 72.98 kB - -
CDN Bundle (incl. Tracing, Replay) 86.56 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.44 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 92.33 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.25 kB - -
CDN Bundle - uncompressed 89.97 kB - -
CDN Bundle (incl. Tracing) - uncompressed 146.69 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 96.26 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.38 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 225.36 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 266.12 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.79 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.81 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.48 kB - -
@sentry/nextjs (client) 53.33 kB - -
@sentry/sveltekit (client) 49.03 kB - -
@sentry/core/server 65.08 kB - -
@sentry/core/browser 52.38 kB - -
@sentry/node 121.79 kB +0.02% +22 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 85.22 kB - -
@sentry/node - without tracing 87.96 kB +0.03% +21 B 🔺
@sentry/aws-serverless 96.14 kB +0.03% +27 B 🔺
@sentry/cloudflare (withSentry) - minified 199.5 kB - -
@sentry/cloudflare (withSentry) 495.46 kB - -

View base workflow run

@andreiborza

Copy link
Copy Markdown
Member Author

Apparently we don't want to bump, closing again. Saver to keep the dev deps on v7 because we still support v7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants