fix(sveltekit): Register the OpenTelemetry tracer provider on Cloudflare - #23632
Merged
Conversation
`initCloudflareSentryHandle` sets `enableOpenTelemetrySetup: true`, but wrapped the request with `wrapRequestHandler` from `@sentry/cloudflare/request`, which initializes the SDK via `initBaseSdk` and ignores that option. Kit tracing spans emitted via `@opentelemetry/api` were therefore dropped. Add an internal, `init`-backed `_INTERNAL_wrapRequestHandler` to the main `@sentry/cloudflare` entry point and use it from SvelteKit. The `/request` entry point stays OTel-free on purpose, as it has to work without `nodejs_compat`. Integration tests pin both behaviours in workerd. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
JPeer264
marked this pull request as ready for review
August 26, 2026 10:21
JPeer264
requested review from
andreiborza,
chargome,
isaacs and
nicohrubec
and removed request for
a team
August 26, 2026 10:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initCloudflareSentryHandlesetsenableOpenTelemetrySetup: true, but wrapped the request withwrapRequestHandlerfrom@sentry/cloudflare/request, which initializes the SDK viainitBaseSdkand ignores that option. Kit tracing spans emitted via@opentelemetry/apiwere therefore dropped.Add an internal,
init-backed_INTERNAL_wrapRequestHandlerto the main@sentry/cloudflareentry point and use it from SvelteKit. The/requestentry point stays OTel-free on purpose, as it has to work withoutnodejs_compat. Integration tests pin both behaviours in workerd.