docs: Streamline the span name changes migration section - #23607
Merged
Conversation
Lms24
force-pushed
the
lms/docs-low-card-db-span-names8
branch
2 times, most recently
from
September 2, 2026 16:41
5d25737 to
f4a6d96
Compare
Lms24
changed the title
Lms24
force-pushed
the
lms/docs-low-card-db-span-names8
branch
2 times, most recently
from
September 2, 2026 17:03
36c71ed to
5363731
Compare
Lms24
marked this pull request as ready for review
September 2, 2026 18:02
s1gr1d
approved these changes
Sep 3, 2026
| #### Cache spans | ||
|
|
||
| Match on attributes instead: | ||
| Cache keys are no longer part of a cache span name. They remain available on the `cache.key` attribute, and every cache span now also carries a `cache.operation` attribute (`get`, `put`, `remove`), which is the value the name is built from. This affects the redis/ioredis cache spans (with `cachePrefixes` set on the redis integration), the Nuxt and Nitro storage spans, and the dataloader spans. |
Member
There was a problem hiding this comment.
You could also mention that maxCacheKeyLength is a no-op now. Similar to useOperationNameForRootSpan.
Member
Author
There was a problem hiding this comment.
hmm good point, thanks! should we deprecate the option then? WDYT?
chargome
approved these changes
Sep 3, 2026
The section had grown into a table followed by ~26 loose paragraphs in no particular order, with a dangling "Some consequences to be aware of:" lead-in sitting halfway down the list. Group the prose under one sub-heading per span op family, ordered to match the table, and move the filtering, sampling and grouping guidance into a section of its own. Fold what the table can carry into the table: `navigation.redirect` shares the `navigation` row instead of a standalone sentence, and `resource.*` moves up next to the other browser ops. Every attribute in this section is set in both trace lifecycles, so state that once up front rather than repeating it in ten paragraphs. Also document the db span names that were still missing: the SQL drivers (`pg`, `postgres.js`, `mysql`, `mysql2`, `knex`, `tedious`, Prisma, Nitro `db0`, Cloudflare D1), mongodb and supabase, plus the new `db.query.summary` attribute. Supabase auth spans do change (`auth signInWithPassword` becomes `auth.signInWithPassword`), and the SQL fallback is not uniformly `Database operation` — each driver drops to the next template it can fill. Refs #23523 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/docs-low-card-db-span-names8
branch
from
September 3, 2026 13:15
26f15f2 to
3181196
Compare
Lms24
enabled auto-merge (squash)
September 3, 2026 13:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With most span name adjustments being taken care of, we accumulated quite a bit of migration guide around the changes. This PR
Refs #22350