feat(core): Emit low-cardinality http.server span names when streaming - #23596
Merged
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
chargome
force-pushed
the
charlygomez/js-3412-http-span-names-core
branch
5 times, most recently
from
August 26, 2026 09:14
09377e8 to
e758901
Compare
Member
Author
|
bugbot run |
chargome
force-pushed
the
charlygomez/js-3412-http-span-names-core
branch
from
August 26, 2026 09:28
e758901 to
826d73b
Compare
chargome
force-pushed
the
charlygomez/js-3412-http-span-names-core
branch
from
August 26, 2026 10:10
826d73b to
7b17d86
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7b17d86. Configure here.
chargome
marked this pull request as ready for review
August 26, 2026 11:39
chargome
requested review from
JPeer264 and
isaacs
and removed request for
a team
August 26, 2026 11:39
chargome
force-pushed
the
charlygomez/js-3412-http-span-names-core
branch
from
August 26, 2026 12:22
7b17d86 to
81ee982
Compare
Lms24
approved these changes
Aug 26, 2026
With span streaming enabled, an http.server span is named after the request method rather than
the URL path when no route is resolved. Routed requests keep `${method} ${route}`, and `static`
mode is unchanged.
The scope's transaction name keeps the full path, so error grouping is unaffected. Two test suites
matched spans by name and now match on `url.path`, which is what is available at span start.
Refs #23527
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
… span Unlike the Node SDK, which renames the root span via `setHttpServerSpanRouteAttribute`, core's express integration only set the isolation scope's transaction name. With span streaming that left routed requests on Bun and Deno stuck with the method-only span name they start with. Gated on span streaming so `static` mode names are unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
charlygomez/js-3412-http-span-names-core
branch
from
August 26, 2026 15:00
81ee982 to
f2795a3
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
chargome
added a commit
that referenced
this pull request
Aug 26, 2026
…23597) Applies the same span-streaming gate across the runtime and framework SDKs so no integration keeps a raw URL in an `http.server` span name; routed requests are unchanged. Stacked on #23596. Worth a closer look: remix reads its own span name back, sveltekit also renames SvelteKit's native root span, and nextjs renames in a `spanStart` hook because Next.js creates that span. Refs #23527 Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names
http.serverspans after the request method instead of the URL path when span streaming is enabled and no route resolved. Routed requests are unchanged,staticmode is byte-identical, and the scope's transaction name keeps the full path so error grouping is unaffected.Refs #23527