Skip to content

ref(ember)!: Change 'ui.ember.component.render' to ui.render #23587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s1gr1d merged 1 commit into from
Aug 25, 2026
+11 −10
Merged

ref(ember)!: Change 'ui.ember.component.render' to ui.render #23587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ import { AppModule } from './app/app.module';
startSpan(
{
name: 'platform-browser-dynamic',
op: 'ui.angular.bootstrap',
op: 'ui.mount',
},
async () => {
await platformBrowserDynamic().bootstrapModule(AppModule);
Expand Down
7 changes: 4 additions & 3 deletions packages/ember/tests/unit/instrument-ember-globals-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { UI_RENDER } from '@sentry/conventions/op';
import type { RenderEntries } from '@sentry/ember/utils/instrumentEmberGlobals';
import {
_processComponentRenderAfter,
Expand All @@ -19,7 +20,7 @@ module('Unit | Utility | instrument-ember-globals', function (hooks) {
_processComponentRenderBefore(payload, beforeEntries);
assert.true(beforeEntries.has(payload), 'Entry is recorded when the render starts');

_processComponentRenderAfter(payload, beforeEntries, 'ui.ember.component.render', 1_000);
_processComponentRenderAfter(payload, beforeEntries, UI_RENDER, 1_000);
assert.false(
beforeEntries.has(payload),
'Entry is removed when the render finishes, so the payload (and the component instance it references) is not retained',
Expand All @@ -31,7 +32,7 @@ module('Unit | Utility | instrument-ember-globals', function (hooks) {
const payload = { containerKey: 'component:test-component', initialRender: true as const, object: '<ember124>' };

_processComponentRenderBefore(payload, beforeEntries);
_processComponentRenderAfter(payload, beforeEntries, 'ui.ember.component.render', 0);
_processComponentRenderAfter(payload, beforeEntries, UI_RENDER, 0);

assert.false(beforeEntries.has(payload), 'Entry is removed after the span is created');
});
Expand All @@ -42,7 +43,7 @@ module('Unit | Utility | instrument-ember-globals', function (hooks) {
const unknownPayload = { containerKey: 'component:unknown', initialRender: true as const, object: '<ember126>' };

_processComponentRenderBefore(trackedPayload, beforeEntries);
_processComponentRenderAfter(unknownPayload, beforeEntries, 'ui.ember.component.render', 1_000);
_processComponentRenderAfter(unknownPayload, beforeEntries, UI_RENDER, 1_000);

assert.true(beforeEntries.has(trackedPayload), 'The in-flight entry is still tracked');
assert.false(beforeEntries.has(unknownPayload), 'The unknown payload was not added');
Expand Down
12 changes: 6 additions & 6 deletions packages/react/src/profiler.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { startInactiveSpan } from '@sentry/browser';
import type { Span } from '@sentry/core';
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, spanToJSON, timestampInSeconds, withActiveSpan } from '@sentry/core';
import { SENTRY_OP } from '@sentry/conventions/attributes';
import { SENTRY_OP, UI_COMPONENT_NAME } from '@sentry/conventions/attributes';
import { UI_MOUNT, UI_RENDER, UI_UPDATE } from '@sentry/conventions/op';
import * as React from 'react';
import { hoistNonReactStatics } from './hoist-non-react-statics';
Expand Down Expand Up @@ -53,7 +53,7 @@ class Profiler extends React.Component<ProfilerProps> {
attributes: {
[SENTRY_OP]: UI_MOUNT,
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.react.profiler',
'ui.component_name': name,
[UI_COMPONENT_NAME]: name,
},
});
}
Expand Down Expand Up @@ -83,7 +83,7 @@ class Profiler extends React.Component<ProfilerProps> {
attributes: {
[SENTRY_OP]: UI_UPDATE,
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.react.profiler',
'ui.component_name': this.props.name,
[UI_COMPONENT_NAME]: this.props.name,
'ui.react.changed_props': changedProps,
},
});
Expand Down Expand Up @@ -117,7 +117,7 @@ class Profiler extends React.Component<ProfilerProps> {
attributes: {
[SENTRY_OP]: UI_RENDER,
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.react.profiler',
'ui.component_name': name,
[UI_COMPONENT_NAME]: name,
},
});
if (renderSpan) {
Expand Down Expand Up @@ -198,7 +198,7 @@ function useProfiler(
attributes: {
[SENTRY_OP]: UI_MOUNT,
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.react.profiler',
'ui.component_name': name,
[UI_COMPONENT_NAME]: name,
},
});
});
Expand All @@ -220,7 +220,7 @@ function useProfiler(
attributes: {
[SENTRY_OP]: UI_RENDER,
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.react.profiler',
'ui.component_name': name,
[UI_COMPONENT_NAME]: name,
},
});
if (renderSpan) {
Expand Down
Loading