feat(browser): Emit low cardinality navigation span names - #23550
Open
logaretm wants to merge 1 commit into
Open
feat(browser): Emit low cardinality navigation span names#23550logaretm wants to merge 1 commit into
logaretm wants to merge 1 commit into
Conversation
Names navigation spans `Navigation` when span streaming is enabled and the SDK has no parameterized route for them. Names in static mode are unchanged.
logaretm
force-pushed
the
awad/js-3407-emit-low-cardinality-navigation-span-names
branch
from
August 24, 2026 18:47
6eeaeb1 to
97991d2
Compare
Contributor
size-limit report 📦
|
logaretm
marked this pull request as ready for review
August 24, 2026 19:38
logaretm
requested review from
Lms24,
chargome,
msonnb and
nicohrubec
and removed request for
a team
August 24, 2026 19:38
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 97991d2. Configure here.
| } else { | ||
| // No matched route - update back-button navigations and set source to url | ||
| const { attributes, name: spanName } = spanToJSON(rootSpan); | ||
| // With span streaming, a back navigation span is already named `Navigation` (there is no |
There was a problem hiding this comment.
Solid overwrites Navigation name
Medium Severity
With span streaming, navigation spans correctly start as Navigation, but this update path can still call updateName with the raw pathname when a match has no route.pattern. That reintroduces a high-cardinality URL name after the fallback was applied.
Reviewed by Cursor Bugbot for commit 97991d2. Configure here.
| span.updateName(pathname); | ||
| // With span streaming, span names have to be low cardinality, so we can't fall back to the URL. | ||
| const client = getClient(); | ||
| span.updateName(client && hasSpanStreamingEnabled(client) ? NAVIGATION_SPAN_NAME_FALLBACK : pathname); |
There was a problem hiding this comment.
Avoidable getClient in utils
Low Severity
This is more an “is this necessary” check than a hard violation: updateNavigationSpanUrlFromLocation newly calls getClient() to gate the streaming name. Callers already have or can receive a client, so threading it through would avoid creating/relying on a current client in multi-client setups.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 97991d2. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names navigation spans
Navigationwhen span streaming is enabled and the SDK has no parameterized route for them. Names in static mode are unchanged.The scope's transaction name keeps the URL, since that's what error events group by.
navigation.redirectspans share the code path so they get the fallback too, which imo is right.closes #23522