Skip to content

test(nextjs): Expect route span source in nextjs-orpc e2e tests - #23537

Merged
chargome merged 1 commit into
developfrom
cg/test/fix-nextjs-orpc-span-source
Aug 24, 2026
Merged

test(nextjs): Expect route span source in nextjs-orpc e2e tests#23537
chargome merged 1 commit into
developfrom
cg/test/fix-nextjs-orpc-span-source

Conversation

@chargome

@chargome chargome commented Aug 24, 2026

Copy link
Copy Markdown
Member

Aligns the nextjs-orpc pageload and navigation expectations with #23503, which started annotating static routes as low-cardinality (source: 'route') but missed this app.

Static routes are now annotated as low-cardinality (`source: 'route'`)
since #23503. That PR updated the expectations in the other Next.js e2e
apps but missed nextjs-orpc, which is an optional test application and
therefore does not run on most pull requests.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@chargome chargome self-assigned this Aug 24, 2026
@chargome
chargome marked this pull request as ready for review August 24, 2026 13:48

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry 😬

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 30.31 kB - -
@sentry/browser - with treeshaking flags 28.48 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 26.82 kB - -
@sentry/browser (incl. Tracing) 48.34 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.34 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.25 kB - -
@sentry/browser (incl. Tracing, Replay) 87.74 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.21 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 92.44 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 105.15 kB - -
@sentry/browser (incl. Feedback) 47.65 kB - -
@sentry/browser (incl. sendFeedback) 35.13 kB - -
@sentry/browser (incl. FeedbackAsync) 40.29 kB - -
@sentry/browser (incl. Metrics) 31.25 kB - -
@sentry/browser (incl. Logs) 31.52 kB - -
@sentry/browser (incl. Metrics & Logs) 32.15 kB - -
@sentry/react 32.1 kB - -
@sentry/react (incl. Tracing) 50.52 kB - -
@sentry/vue 35.36 kB - -
@sentry/vue (incl. Tracing) 50.33 kB - -
@sentry/svelte 30.34 kB - -
CDN Bundle 31.62 kB - -
CDN Bundle (incl. Tracing) 48.82 kB - -
CDN Bundle (incl. Logs, Metrics) 33.81 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 50.73 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 74.32 kB - -
CDN Bundle (incl. Tracing, Replay) 86.31 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.16 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 92.04 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 93.97 kB - -
CDN Bundle - uncompressed 93.9 kB - -
CDN Bundle (incl. Tracing) - uncompressed 146.08 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.2 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 151.77 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 229.13 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 265.35 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.02 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.05 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 284.71 kB - -
@sentry/nextjs (client) 53.06 kB - -
@sentry/sveltekit (client) 48.77 kB - -
@sentry/core/server 65.85 kB - -
@sentry/core/browser 52.05 kB - -
@sentry/node 117.49 kB +0.03% +24 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 85.18 kB - -
@sentry/node - without tracing 82.03 kB +0.03% +24 B 🔺
@sentry/aws-serverless 91.46 kB +0.03% +21 B 🔺
@sentry/cloudflare (withSentry) - minified 194.68 kB - -
@sentry/cloudflare (withSentry) 481.33 kB - -

View base workflow run

@chargome
chargome merged commit f1552cb into develop Aug 24, 2026
43 checks passed
@chargome
chargome deleted the cg/test/fix-nextjs-orpc-span-source branch August 24, 2026 13:55
JPeer264 pushed a commit that referenced this pull request Aug 25, 2026
…3537)

Aligns the `nextjs-orpc` pageload and navigation expectations with
#23503, which started annotating static routes as low-cardinality
(`source: 'route'`) but missed this app.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants