fix(remix): Treat static route span names as low-cardinality names - #23504
Merged
Lms24 merged 2 commits intoAug 24, 2026
Conversation
Contributor
size-limit report 📦
|
Lms24
changed the title
Lms24
changed the title
Lms24
force-pushed
the
lms/fix-remix-static-route-parameterization
branch
from
August 24, 2026 09:34
079f5f1 to
7627ab7
Compare
`findMatchingRoutes` returned nothing for a path that exactly matched a static route in the build-time manifest, so `maybeParameterizeRemixRoute` reported it the same way as a path it could not resolve at all: no manifest (the Vite plugin is opt-in, and the classic compiler never injects one), a 404, or a route the file-convention scanner missed. Static routes were therefore emitted with `sentry.source: 'url'` and no `url.template`, even though a static route is its own template - one with zero parameters - and is guaranteed low cardinality by the finite build-time route list. Return the route itself instead. Pageload and navigation spans both derive their name, source and `url.template` from that return value, so static routes now carry `sentry.source: 'route'`. Under span streaming they keep their path as the span name instead of collapsing to `Pageload`, which is now reserved for paths the manifest genuinely cannot resolve. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/fix-remix-static-route-parameterization
branch
from
August 24, 2026 10:58
3859679 to
176c9d4
Compare
Lms24
marked this pull request as ready for review
August 24, 2026 11:01
Lms24
requested review from
chargome and
nicohrubec
and removed request for
a team
August 24, 2026 11:01
chargome
approved these changes
Aug 24, 2026
nicohrubec
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #23503