feat(node): Ensure orchestrion runtime is injected when integration is passed - #23471
feat(node): Ensure orchestrion runtime is injected when integration is passed#23471mydea wants to merge 1 commit into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0af2bbc. Configure here.
|
|
||
| expect(registerDiagnosticsChannelInjection).not.toHaveBeenCalled(); | ||
| expect(detectOrchestrionSetup).not.toHaveBeenCalled(); | ||
| }); |
There was a problem hiding this comment.
Missing integration or E2E test
Medium Severity
This is a feat PR, but coverage is only mocked unit tests around registerDiagnosticsChannelInjection. Per the PR review guidelines, a feat needs at least one integration or E2E test. An integration test that init with a channel integration and tracing off, then asserts real error capture, would lock in the production path this change is meant to fix.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 0af2bbc. Configure here.
| return options.integrations.some(integration => | ||
| (AUTO_PERFORMANCE_INTEGRATION_NAMES as readonly string[]).includes(integration.name), | ||
| ); | ||
| } |
There was a problem hiding this comment.
Non-orchestrion names gate injection
Low Severity
hasUserConfiguredChannelIntegration treats every AUTO_PERFORMANCE_INTEGRATION_NAMES entry as orchestrion-backed, but Prisma and Fastify are not. Passing only those with tracing off still calls registerDiagnosticsChannelInjection, installing module hooks that those integrations never use.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 0af2bbc. Configure here.
size-limit report 📦
|
1 participant
Today, we auto-inject the orchestrion runtime when tracing is enabled.
However, if you manually pass an integration that depends on orchestrion, this would not work. This PR changes this so we also inject orchestrion if a tracing integration is passed.
This is relevant e.g. if you add an integration without tracing for error support.