ref(node)!: Remove deprecated fastify exports, deprecate setupFastifyErrorHandler - #23460
Open
mydea wants to merge 9 commits into
Open
ref(node)!: Remove deprecated fastify exports, deprecate setupFastifyErrorHandler#23460mydea wants to merge 9 commits into
setupFastifyErrorHandler#23460mydea wants to merge 9 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d9cdd33. Configure here.
mydea
marked this pull request as ready for review
August 20, 2026 10:53
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
mydea
marked this pull request as draft
August 20, 2026 11:33
mydea
force-pushed
the
fn/streamline-fastify
branch
from
August 20, 2026 13:37
3004b8c to
3a04de5
Compare
mydea
marked this pull request as ready for review
August 20, 2026 13:55
Comment on lines
+409
to
+411
| fastify.addHook('onError', async (request, reply, error) => { | ||
| handleFastifyError(error, request, reply); | ||
| }); |
Contributor
There was a problem hiding this comment.
Bug: Primitive errors thrown in Fastify v5 route handlers are captured twice because the deduplication logic in checkOrSetAlreadyCaught fails for non-object types.
Severity: LOW
Suggested Fix
Wrap primitive errors in a new Error object within the handleFastifyError function before they are passed to checkOrSetAlreadyCaught and captureException. This will allow the __sentry_captured__ property to be set correctly, ensuring the error is only captured once.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/server-utils/src/integrations/fastify/instrumentation.ts#L409-L411
Potential issue: In Fastify v5, when a primitive value like a string or number is thrown
in a route handler, it gets captured and sent to Sentry twice. This occurs because two
separate error handling paths, the `tracing:fastify.request.handler:error` diagnostics
channel and the `onError` hook, both attempt to report the error. The deduplication
mechanism, `checkOrSetAlreadyCaught`, is designed to prevent this by setting a
`__sentry_captured__` property on the error. However, this function cannot set
properties on primitive values, causing the deduplication to fail silently and both
paths to report the same error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes deprecated/unneeded fastify exports.
It also deprecates
setupFastifyErrorHandler- it is no longer needed. instead, you can fully configure the error handler for all versions of fastify now via the integration.I also removed the override tests from e2e tests, instead testing that you can still override the error handler in a node-integration-test.