Skip to content

ref(cloudflare)!: Remove wrapRequestHandlerWithInit as export - #23322

Merged
JPeer264 merged 1 commit into
jp/cloudflare-tracerproviderfrom
jp/remove-export
Aug 25, 2026
Merged

ref(cloudflare)!: Remove wrapRequestHandlerWithInit as export#23322
JPeer264 merged 1 commit into
jp/cloudflare-tracerproviderfrom
jp/remove-export

Conversation

@JPeer264

@JPeer264 JPeer264 commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This was added by accident in the first v11 alpha. The /request entrypoint should only export wrapRequestHandler and nothing else.

This PR only moves the export in its own file

@JPeer264 JPeer264 self-assigned this Aug 12, 2026
@JPeer264
JPeer264 requested a review from a team as a code owner August 12, 2026 09:04
@JPeer264
JPeer264 requested review from isaacs and mydea and removed request for a team August 12, 2026 09:04
@github-actions

github-actions Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 28.57 kB - -
@sentry/browser - with treeshaking flags 26.92 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 26.82 kB - -
@sentry/browser (incl. Tracing) 48.34 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.36 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.25 kB - -
@sentry/browser (incl. Tracing, Replay) 87.74 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.2 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 92.45 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 105.13 kB - -
@sentry/browser (incl. Feedback) 45.81 kB - -
@sentry/browser (incl. sendFeedback) 33.36 kB - -
@sentry/browser (incl. FeedbackAsync) 38.47 kB - -
@sentry/browser (incl. Metrics) 29.52 kB - -
@sentry/browser (incl. Logs) 29.8 kB - -
@sentry/browser (incl. Metrics & Logs) 30.45 kB - -
@sentry/react 30.33 kB - -
@sentry/react (incl. Tracing) 50.52 kB - -
@sentry/vue 35.4 kB - -
@sentry/vue (incl. Tracing) 50.32 kB - -
@sentry/svelte 28.6 kB - -
CDN Bundle 30.32 kB - -
CDN Bundle (incl. Tracing) 48.87 kB - -
CDN Bundle (incl. Logs, Metrics) 32.54 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 50.74 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 72.91 kB - -
CDN Bundle (incl. Tracing, Replay) 86.33 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.16 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 92.07 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94 kB - -
CDN Bundle - uncompressed 89.94 kB - -
CDN Bundle (incl. Tracing) - uncompressed 146.13 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 96.23 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 151.81 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 225.18 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 265.4 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.07 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.09 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 284.76 kB - -
@sentry/nextjs (client) 53.07 kB - -
@sentry/sveltekit (client) 48.76 kB - -
@sentry/core/server 64.95 kB - -
@sentry/core/browser 52.11 kB - -
@sentry/node 117.54 kB +0.07% +78 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 85.18 kB - -
@sentry/node - without tracing 82.08 kB +0.1% +75 B 🔺
@sentry/aws-serverless 91.51 kB +0.09% +75 B 🔺
@sentry/cloudflare (withSentry) - minified 196.3 kB +0.83% +1.61 kB 🔺
@sentry/cloudflare (withSentry) 485.93 kB +0.97% +4.64 kB 🔺

View base workflow run

@JPeer264
JPeer264 requested review from chargome and nicohrubec and removed request for isaacs August 13, 2026 14:32
nicohrubec
nicohrubec approved these changes Aug 13, 2026
View reviewed changes

@nicohrubec nicohrubec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not a fix?

@JPeer264

JPeer264 commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

is this not a fix?

Probably. Best would be ref maybe.

@JPeer264 JPeer264 changed the title feat(cloudflare)!: Remove wrapRequestHandlerWithInit as export ref(cloudflare)!: Remove wrapRequestHandlerWithInit as export Aug 13, 2026
@JPeer264
JPeer264 merged commit 79a0430 into develop Aug 25, 2026
119 checks passed
@JPeer264
JPeer264 deleted the jp/remove-export branch August 25, 2026 08:36
JPeer264 added a commit that referenced this pull request Aug 25, 2026
@JPeer264
ref(cloudflare)!: Remove wrapRequestHandlerWithInit as export (#23322)
0776d99 
This was added by accident in the first v11 alpha. The `/request`
entrypoint should only export `wrapRequestHandler` and nothing else.

This PR only moves the export in its own file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicohrubec nicohrubec nicohrubec approved these changes
@andreiborza andreiborza andreiborza approved these changes
@mydea mydea Awaiting requested review from mydea mydea is a code owner automatically assigned from getsentry/team-javascript-sdks-server
@chargome chargome Awaiting requested review from chargome

Assignees

@JPeer264 JPeer264

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JPeer264 @nicohrubec @andreiborza