feat(v10/core)!: Enable logs by default - #23311
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
nicohrubec
force-pushed
the
feat/v10-enable-logs-by-default
branch
2 times, most recently
from
August 11, 2026 19:14
68b7ff1 to
c282a54
Compare
nicohrubec
marked this pull request as ready for review
August 11, 2026 19:30
nicohrubec
requested review from
JPeer264,
Lms24,
andreiborza,
chargome,
logaretm,
mydea and
s1gr1d
and removed request for
a team
August 11, 2026 19:30
logaretm
approved these changes
Aug 11, 2026
Member
|
Do we ship now breaking changes into v10? |
Member
Author
|
@JPeer264 not as a principle no, but there was some push to get this out soon so we might wanna do this in a minor. I'll hold off merging until we confirm we wanna do this |
Member
|
Technically it is a fix, since it should have never been shipped like that 🤔 |
nicohrubec
changed the title
s1gr1d
approved these changes
Aug 12, 2026
|
|
||
| - **feat(v10/core)!: Enable logs by default ([#23311](https://github.com/getsentry/sentry-javascript/pull/23311))** | ||
|
|
||
| The `enableLogs` client option now defaults to `true`, so Sentry Logs work without any manual opt-in. Nothing is captured unless you call the `Sentry.logger.*` APIs or add a log-forwarding integration (such as `consoleLoggingIntegration`, `pinoIntegration`, or the winston transport), and you can set `enableLogs: false` to opt out entirely. |
Member
There was a problem hiding this comment.
Maybe we should point out here that we're aware that we don't follow semantic versioning here.
nicohrubec
changed the title
Backport of: #22630
nicohrubec
force-pushed
the
feat/v10-enable-logs-by-default
branch
from
August 12, 2026 09:48
c282a54 to
aa30c92
Compare
JPeer264
approved these changes
Aug 12, 2026
Lms24
previously requested changes
Aug 21, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
Let's not yet merge this please. I think we should talk about this again on Monday.
Lms24
dismissed
their stale review
August 24, 2026 11:40
After talking about this again, we decided to move on with this change, given there is still a way to disable logging and our logging integrations are already telemetry-separated and not enabled by default.
For some context: My concern was negative feedback after the Python SDK shipped a very similar change though the situation for them was slightly different to ours: Enabling logs by default produced more logs than explicit sentry logger calls, as they already had integrations that emitted logs by default (convoluted with other telemetry). Shipping our change here is still behaviour breaking but we can justify it to an extent.
46 tasks
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #22630
Flips the
enableLogsclient option to default totrueso users get logs without opting in, matching howenableMetricsalready behaves. An explicitenableLogs: falseturns it back off. Unless a logging integration is added or an explicit logging API is called no logs are emitted.Main difference to the original PR is that on v10 node and node-core are still separate packages so we need a few changes in both. Also added a changelog entry since this is a behavioral change.
Docs also need updating.