Skip to content

ref(cloudflare): Build context descriptors in one pass #23131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JPeer264 merged 1 commit into from
Aug 7, 2026
Merged

ref(cloudflare): Build context descriptors in one pass #23131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions packages/cloudflare/src/utils/instrumentContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,16 @@ export function instrumentContext<T extends ContextType>(ctx: T): T {
const prototypeMethodNames = Object.getOwnPropertyNames(contextPrototype) as unknown as (keyof T)[];
const ownPropertyNames = Object.getOwnPropertyNames(ctx) as unknown as (keyof T)[];
const instrumented = new Set<unknown>(['constructor']);
const descriptors: PropertyDescriptorMap = [...ownPropertyNames, ...prototypeMethodNames].reduce(
(prevDescriptors, methodName) => {
if (instrumented.has(methodName)) return prevDescriptors;
if (typeof ctx[methodName] !== 'function') return prevDescriptors;
instrumented.add(methodName);
const overridableDescriptor = makeOverridableDescriptor(overrides, ctx, methodName);
return {
...prevDescriptors,
[methodName]: overridableDescriptor,
};
},
{} as PropertyDescriptorMap,
);
const descriptors: PropertyDescriptorMap = {};

for (const methodName of [...ownPropertyNames, ...prototypeMethodNames]) {
if (instrumented.has(methodName) || typeof ctx[methodName] !== 'function') {
continue;
}

instrumented.add(methodName);
descriptors[methodName as string] = makeOverridableDescriptor(overrides, ctx, methodName);
}

// Check if this is a DurableObjectState context with a storage property
// If so, wrap the storage with instrumentation
Expand Down
Loading