feat(server-utils)!: Clean up gen ai ops - #23076
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot lauf |
msonnb
force-pushed
the
ms/gen-ai-ops
branch
2 times, most recently
from
August 6, 2026 11:56
9256efb to
531ee7b
Compare
msonnb
marked this pull request as ready for review
August 6, 2026 12:11
msonnb
requested review from
andreiborza,
isaacs,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team,
isaacs,
mydea and
s1gr1d
August 6, 2026 12:11
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 531ee7b. Configure here.
| */ | ||
| export function getGenAiSpanOp(operationName: string): string { | ||
| return NON_INFERENCE_OPERATIONS.has(operationName) ? GENERAL_FUNCTION_SPAN_OP : `gen_ai.${operationName}`; | ||
| } |
There was a problem hiding this comment.
Missing migration notes for span ops
Medium Severity
This ! breaking change renames many user-visible span ops (handler → request_handler.* / handler.nestjs, function → framework-specific ops, gen_ai.models / ai.run → function, Bedrock rpc → gen_ai.*, Hono internal http.server → hono.request, Hapi plugin handler → plugin.hapi) but does not update MIGRATION.md. That violates the Breaking Changes review rule: similar op renames are already documented there for dashboards, alerts, and ignoreSpans filters.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 531ee7b. Configure here.
andreiborza
approved these changes
Aug 6, 2026
- Use `gen_ai.chat` / `gen_ai.generate_content` ops for AWS Bedrock Converse and InvokeModel spans instead of the generic `rpc` op, and set `gen_ai.operation.name` plus a gen_ai-style span name on both. - Use `function` as a fallback op instead of `gen_ai.unknown` and `ai.run`. - Use `function` instead of `gen_ai.models` for model metadata calls. part of #22446 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
nicohrubec
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen_ai.chatandgen_ai.invoke_modelinstead ofrpcfor AWS Bedrock spansfunctionas a fallback op instead ofgen_ai.unknownandai.runfunctioninstead ofgen_ai.modelsfor model metadata callspart of #22446