chore(server-utils): Simplify injectChannelSubscribers - #23033
Merged
Conversation
timfish
requested review from
JPeer264,
isaacs,
msonnb and
stephanie-anderson
and removed request for
a team,
msonnb and
stephanie-anderson
August 4, 2026 23:34
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
timfish
marked this pull request as draft
August 4, 2026 23:46
timfish
marked this pull request as ready for review
August 5, 2026 10:40
JPeer264
approved these changes
Aug 5, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
Amazing thanks for simplifying that
| @@ -1,5 +1,4 @@ | |||
| import type { InstrumentationConfig } from '..'; | |||
| import { toSubscribeInjections } from './subscribe-injection'; | |||
Member
There was a problem hiding this comment.
nothing to act in this PR. I just saw that we don't have getModuleNames in this integration. We might have missed that.
cc @isaacs is that something we should add?
| @@ -1,5 +1,4 @@ | |||
| import type { InstrumentationConfig } from '..'; | |||
| import { toSubscribeInjections } from './subscribe-injection'; | |||
Member
There was a problem hiding this comment.
| @@ -1,5 +1,4 @@ | |||
| import type { InstrumentationConfig } from '..'; | |||
| import { toSubscribeInjections } from './subscribe-injection'; | |||
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the
injectChannelSubscribersorchestrion bundler feature to use the latest orchestrion-js feature which allows us to inject into every module we were already injecting into, rather than having to use additional injections to do this.