test(dataCollection): Remove all occurences of sendDefaultPii in unit tests - #22913
Merged
Conversation
s1gr1d
requested review from
JPeer264,
chargome,
isaacs,
logaretm,
msonnb and
nicohrubec
and removed request for
a team
July 31, 2026 11:19
s1gr1d
marked this pull request as draft
July 31, 2026 11:23
s1gr1d
force-pushed
the
sig/remove-sendDefaultPii-unit-test
branch
from
July 31, 2026 12:13
e466885 to
cf9d4db
Compare
s1gr1d
marked this pull request as ready for review
July 31, 2026 12:23
logaretm
approved these changes
Jul 31, 2026
chargome
added a commit
that referenced
this pull request
Aug 3, 2026
First merge this PR (is merged): #22913 Enable the `dataCollection` specification defaults when neither `dataCollection` nor the legacy `sendDefaultPii` option is configured. Tests and development test applications now rely on the new defaults instead of redundantly opting into `userInfo` and related data. closes #22707 --------- Co-authored-by: Charly Gomez <charly.gomez1310@gmail.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step of removing
sendDefaultPii. We still need to set an explicittruevalue to enable collection (this is changed in a follow-up to not get too large PRs).part of #22708