feat(nestjs)!: Use function span op for setup & lifecycle handlers - #22897
Merged
msonnb merged 1 commit intoAug 6, 2026
Merged
Conversation
Contributor
size-limit report 📦
|
msonnb
force-pushed
the
ms/js-3105-lifecycle-function-op
branch
from
July 31, 2026 08:12
cfddf2c to
5390356
Compare
msonnb
changed the title
function span op for setup & lifecycle handlersfunction span op for setup & lifecycle handlers
msonnb
marked this pull request as ready for review
July 31, 2026 08:22
msonnb
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
July 31, 2026 08:22
msonnb
force-pushed
the
ms/js-3105-lifecycle-function-op
branch
from
August 4, 2026 08:53
5390356 to
7bdc904
Compare
msonnb
force-pushed
the
ms/js-3105-lifecycle-function-op
branch
from
August 5, 2026 15:51
7bdc904 to
f9519b4
Compare
Lms24
approved these changes
Aug 5, 2026
Migrate the NestJS setup/lifecycle span ops to the cross-framework `function` op: - `app_creation.nestjs` -> `function` - `request_context.nestjs` -> `function` - `event.nestjs` -> `function` Op is set via the `sentry.op` attribute only; the `nestjs.type` attribute (`app_creation` / `request_context` / `handler`) is unchanged, so span-shape filters keep working. Lookups that previously keyed on the distinct `request_context` op are re-keyed on `nestjs.type`, since it now shares the `function` op and `auto.http.nestjs` origin with the request handler span. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
msonnb
force-pushed
the
ms/js-3105-lifecycle-function-op
branch
from
August 6, 2026 09:57
f9519b4 to
fed2041
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fed2041. Configure here.
| @@ -1,5 +1,5 @@ | |||
| import { SENTRY_OP } from '@sentry/conventions/attributes'; | |||
| import { WEB_SERVER_MIDDLEWARE_SPAN_OP } from '@sentry/conventions/op'; | |||
| import { WEB_SERVER_FUNCTION_SPAN_OP, WEB_SERVER_MIDDLEWARE_SPAN_OP } from '@sentry/conventions/op'; | |||
There was a problem hiding this comment.
Wrong function span op constant
High Severity
This migration imports WEB_SERVER_FUNCTION_SPAN_OP, but the cross-framework function op constant used elsewhere in this repo is GENERAL_FUNCTION_SPAN_OP (see Angular and Cloudflare). function is a general-category op, not a web-server one, so this constant name does not match the intended shared convention and is not used anywhere else in the monorepo.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit fed2041. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the NestJS setup/lifecycle span ops to the cross-framework
functionop.app_creation.nestjsfunctionrequest_context.nestjsfunctionevent.nestjsfunctionPart of #22446