feat(browser): Migrate sendDefaultPii to dataCollection in browser packages#21097
Open
chargome wants to merge 3 commits into
Open
feat(browser): Migrate sendDefaultPii to dataCollection in browser packages#21097chargome wants to merge 3 commits into
sendDefaultPii to dataCollection in browser packages#21097chargome wants to merge 3 commits into
Conversation
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eb71e9e. Configure here.
Contributor
size-limit report 📦
|
logaretm
approved these changes
May 26, 2026
logaretm
reviewed
May 26, 2026
Member
logaretm
left a comment
logaretm
left a comment
There was a problem hiding this comment.
Maybe we should add tests to lock down the new sensitive header filtering behavior
s1gr1d
approved these changes
May 26, 2026
Member
s1gr1d
left a comment
s1gr1d
left a comment
There was a problem hiding this comment.
Looks good, also read the comment from the AI review, but I would consider that a fix (see comment above).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
browser/src/client.ts: Migrate todataCollectionforinfer_iprelay setting andaddAutoIpAddressToSessionlistenerbrowser/src/integrations/httpclient.ts: Split singlesendDefaultPiigate into granularcookies,httpHeaders.request,httpHeaders.responsechecks with new collect behavior filtering. Includes a backwards-compat guard so legacysendDefaultPiiusers see no behavioral change (deferred to v11).browser-utils/src/metrics/utils.ts: Migrate todataCollectionforclient.addressspan attributeNote on backwards compatibility:
When
dataCollectionis not explicitly set by the user, the httpclient integration falls back to the oldsendDefaultPiiboolean gate (all-or-nothing). This avoids silently sending more data for existing users. WhendataCollectionis explicitly set, the granular filtering is applied. (#21094)closes #20929