fix(feedback)!: always reject sendFeedback with an Error - #20475
Merged
Conversation
logaretm
changed the title
logaretm
changed the base branch from
develop
to
awad/js-126-allow-error-messages-to-be-customized
April 24, 2026 03:06
logaretm
force-pushed
the
awad/js-126-feedback-error-rejections-breaking
branch
from
April 24, 2026 03:14
29f92e6 to
90ef1af
Compare
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/js-126-feedback-error-rejections-breaking
branch
3 times, most recently
from
April 24, 2026 06:18
44d8d3c to
fdc6ca4
Compare
logaretm
force-pushed
the
awad/js-126-allow-error-messages-to-be-customized
branch
2 times, most recently
from
April 24, 2026 13:19
90ec385 to
029c535
Compare
Base automatically changed from
awad/js-126-allow-error-messages-to-be-customized
to
develop
April 24, 2026 13:44
logaretm
force-pushed
the
awad/js-126-feedback-error-rejections-breaking
branch
2 times, most recently
from
August 25, 2026 17:49
6dfac86 to
7abb2f0
Compare
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7abb2f0. Configure here.
logaretm
force-pushed
the
awad/js-126-feedback-error-rejections-breaking
branch
2 times, most recently
from
August 25, 2026 18:09
31d6ad3 to
83c33f3
Compare
logaretm
marked this pull request as ready for review
August 25, 2026 18:09
logaretm
requested review from
Lms24 and
msonnb
and removed request for
a team
August 25, 2026 18:09
msonnb
approved these changes
Aug 26, 2026
Previously, sendFeedback's async rejection paths (timeout, 403, generic transport error) rejected with a plain string, while the sync-throw paths (empty message, no client) threw an Error. Unify on Error for all paths so consumers can rely on a consistent rejection shape. BREAKING CHANGE: sendFeedback now rejects with an Error instead of a string. The message text is unchanged and is still customizable via the `errorMessages` hint, so consumers reading it should switch from the rejection value itself to `error.message`.
logaretm
force-pushed
the
awad/js-126-feedback-error-rejections-breaking
branch
from
August 26, 2026 20:12
83c33f3 to
f975f36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendFeedbackcurrently rejects with anErrorin some paths and a raw string in others. This normalizes all paths to reject with anError, which is the expected shape and easier to handle for consumers.Breaking: intended for the next major.