Skip to content

deno: tests run with --no-check #23899

Closed

Description

@isaacs

packages/deno/package.json: deno test ... --no-check. Type errors in Deno test files never fail CI. lint:types covers src only.

Either drop --no-check, or add a separate deno check test/ step. Measure the added CI time first; --no-check may have been added for speed.

Activity

  1. linear-code commented on Sep 2, 2026

    @linear-code
  2. added
    javascriptPull requests that update javascript code
    on Sep 2, 2026
  3. Philip-Nwabuwa commented on Oct 9, 2026

    @Philip-Nwabuwa
    Contributor

    I would like to take this. I'll time the current deno test ... --no-check run in packages/deno, then compare dropping --no-check against a separate deno check test/ step. I'll open a PR with the faster option that still fails CI on type errors in the test files, and include the timing in the description. Please say if this is already being worked on.

  4. added 2 commits that reference this issue on Oct 9, 2026
    01e74d6
    4229a6e
  5. JPeer264 commented on Oct 9, 2026

    @JPeer264
    Member

    Thanks. I'll take a look at your PR.

  6. added a commit that references this issue on Oct 11, 2026
    0df3903
  7. github-actions commented on Oct 12, 2026

    @github-actions
    Contributor

    A PR closing this issue has just been released 🚀

    This issue was referenced by PR #25227, which was included in the 11.7.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    DenoTestsjavascriptPull requests that update javascript code

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions