Skip to content

ref: Remove the remaining Throwable catches that guard nothing (JAVA-552) - #6668

Open
runningcode wants to merge 1 commit into
9.x.xfrom
no/java-552-remove-unneeded-catches
Open

runningcode wants to merge 1 commit into
9.x.xfrom
no/java-552-remove-unneeded-catches

Conversation

@runningcode

@runningcode runningcode commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

📜 Description

Removes three catch (Throwable) blocks that guard nothing: the code inside them already catches its own failures or can't throw. No behavior change.

💡 Motivation and Context

This is part of the catch (Throwable) audit. It's independent of the other JAVA-552 PRs, so it can merge in any order.

💚 How did you test it?

No new tests, since nothing changes behavior. The existing tests pass.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

#skip-changelog

🤖 Generated with Claude Code

The catches in ClientReportRecorder.recordLostEnvelope and recordLostEvent wrap callees that already catch their own failures, and the one in ContextUtils wraps a read of split APK info that DeviceInfoUtil has already cached.

Refs #5513

Refs JAVA-552

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Nov 18, 2026

Copy link
Copy Markdown

JAVA-552

@sentry

sentry Bot commented Nov 18, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.64.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions github-actions Bot added risk: high PR risk score: high and removed risk: high PR risk score: high labels Nov 19, 2026
@runningcode
runningcode marked this pull request as ready for review November 19, 2026 15:12
@runningcode
runningcode requested review from a team and adinauer as code owners November 19, 2026 15:12
@runningcode
runningcode requested review from 0xadam-brown and markushi and removed request for a team November 19, 2026 15:12
@github-actions github-actions Bot added risk: high PR risk score: high and removed risk: high PR risk score: high labels Nov 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR risk: high

For commit a2ba7e8.

Main concerns: reach, host stability, data sent to Sentry.

This label is a hint for reviewers, not an approval.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: high PR risk score: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant