Skip to content

chore(deps): [Servlet API 1] Bump javax.servlet API to 4.0.1 - #6475

Merged
runningcode merged 1 commit into
chore/servlet-api-compatibility-stackfrom
dependabot/gradle/javax.servlet-javax.servlet-api-4.0.1
Nov 17, 2026
Merged

runningcode merged 1 commit into
chore/servlet-api-compatibility-stackfrom
dependabot/gradle/javax.servlet-javax.servlet-api-4.0.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

PR Stack (Servlet API)


📜 Description

Bump javax.servlet:javax.servlet-api from 3.1.0 to 4.0.1.

Upstream changes

💡 Motivation and Context

Keep the javax.servlet compile dependency current. The next PR in this stack runs the same integration test on Tomcat 8.5 / Servlet 3.1 and Tomcat 9 / Servlet 4.0.

💚 How did you test it?

Dependabot CI covers the dependency update. PR #6625 adds explicit runtime coverage for both Servlet 3.1 and Servlet 4.0.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

Merge PR #6625 into this branch with a merge commit before merging this PR into the collection branch.

#skip-changelog

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

@dependabot
dependabot Bot requested review from a team and adinauer as code owners November 6, 2026 04:13
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file Java SDK labels Nov 6, 2026
@dependabot
dependabot Bot requested review from 0xadam-brown and runningcode and removed request for a team November 6, 2026 04:13
@sentry

sentry Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.64.0 (1) release

⚙️ sentry-android Build Distribution Settings

@runningcode

Copy link
Copy Markdown
Contributor

@adinauer could you take a look?

Bumps [javax.servlet:javax.servlet-api](https://github.com/javaee/servlet-spec) from 3.1.0 to 4.0.1.
- [Commits](javaee/servlet-spec@3.1.0...4.0.1)

---
updated-dependencies:
- dependency-name: javax.servlet:javax.servlet-api
  dependency-version: 4.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/gradle/javax.servlet-javax.servlet-api-4.0.1 branch from c08ccfc to c7d7307 Compare November 13, 2026 12:36

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c7d7307. Configure here.

Comment thread gradle/libs.versions.toml Resolved
@adinauer adinauer changed the title chore(deps): bump javax.servlet:javax.servlet-api from 3.1.0 to 4.0.1 chore(deps): [Servlet API 1] Bump javax.servlet API to 4.0.1 Nov 16, 2026
@adinauer
adinauer changed the base branch from main to chore/servlet-api-compatibility-stack November 16, 2026 14:10
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Nov 16, 2026
@github-actions github-actions Bot added risk: low PR risk score: low and removed risk: medium PR risk score: medium labels Nov 16, 2026
@runningcode
runningcode merged commit 98875ae into chore/servlet-api-compatibility-stack Nov 17, 2026
54 of 55 checks passed
@runningcode
runningcode deleted the dependabot/gradle/javax.servlet-javax.servlet-api-4.0.1 branch November 17, 2026 07:05
@adinauer

Copy link
Copy Markdown
Member

Follow-up after review: the collection branch restores javax.servlet-api:3.1.0 as the production compile target and excludes the intentionally pinned dependency from Dependabot. PR #6625 retains runtime coverage for both Servlet 3.1 and Servlet 4.0.

adinauer added a commit that referenced this pull request Nov 20, 2026
* collection: Servlet API compatibility

* chore(deps): bump javax.servlet:javax.servlet-api from 3.1.0 to 4.0.1 (#6475)

Bumps [javax.servlet:javax.servlet-api](https://github.com/javaee/servlet-spec) from 3.1.0 to 4.0.1.
- [Commits](javaee/servlet-spec@3.1.0...4.0.1)

---
updated-dependencies:
- dependency-name: javax.servlet:javax.servlet-api
  dependency-version: 4.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(servlet): Keep Servlet 3.1 as compatibility floor

Compile the javax servlet integrations against the minimum supported API.
Exclude the intentionally pinned API from Dependabot while retaining the
separate Servlet 4 alias for latest-runtime coverage.

Co-Authored-By: Claude <noreply@anthropic.com>

* test(servlet): Test Servlet 3.1 and 4.0 runtimes (#6625)

* test(servlet): Test Servlet 3.1 on Tomcat 8.5

Run sentry-servlet against the minimum supported servlet container while
keeping Servlet 3.1 as the production compile target. Exercise the
service-loaded initializer through a real HTTP request and verify that
request context reaches Sentry.

* test(servlet): Run integration test on Tomcat 9

Reuse the real-container servlet integration test with a Tomcat 9 and Servlet 4 runtime classpath. Keep the Tomcat 8.5 run as the minimum-runtime check and attach both runs to the verification lifecycle.

* build(servlet): Use JVM test suites for Tomcat matrix

Replace the hand-built Tomcat 9 test task with isolated JVM test suites.
Run the shared servlet integration test with independent Tomcat 8.5 and
Tomcat 9 dependency graphs and attach both suites to check.

Co-Authored-By: Claude <noreply@anthropic.com>

* build(servlet): Remove unused Truth dependency

The servlet integration suites declare Truth directly, so the regular unit
test configuration no longer needs it after moving the integration test.

Co-Authored-By: Claude <noreply@anthropic.com>

* build(deps): Share the Tomcat 9 version

Reference one catalog version from the Tomcat 9 core, Catalina, and Jasper
aliases so dependency updates keep the runtime components aligned.

Co-Authored-By: Claude <noreply@anthropic.com>

* test(servlet): Run Tomcat matrix in dedicated CI job

Compile the servlet integration test once and execute it with separate
Tomcat 8.5 and Tomcat 9 runtime targets. Move both targets out of the
standard check lifecycle and run them in a dedicated CI job.

Co-Authored-By: Claude <noreply@anthropic.com>

* ci: Move integration tests to dedicated workflow

Create a shared workflow for non-Spring Boot integration suites and move the
servlet runtime matrix there instead of adding it to the main build workflow.

Co-Authored-By: Claude <noreply@anthropic.com>

* ci: Restrict integration test workflow permissions

Limit the workflow token to read-only repository contents because the test, artifact, and step-summary operations do not require write access.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

* build(deps): Share the Tomcat 11 version

Restore Tomcat 11.0.27 after the collection branch merge and use one catalog version for Catalina and embedded Jasper so future updates keep them aligned.

Co-Authored-By: Claude <noreply@anthropic.com>

* Revert "fix(replay): Support Compose 1.13 and mask Compose views that can't be traversed (#6626)"

This reverts commit 7eda470.

Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io>

* Reapply "fix(replay): Support Compose 1.13 and mask Compose views that can't be traversed (#6626)"

This reverts commit ee14ece.

Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io>

* build: Lower Gradle daemon heap to 7g and metaspace to 1g

Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io>

* build: Restore 8g Gradle heap and cap Kotlin daemon heap at 3g

Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Co-authored-by: Nelson Osacky <nelson.osacky@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file Java SDK risk: low PR risk score: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants