-
-
Notifications
You must be signed in to change notification settings - Fork 475
perf(android): Defer Session Replay start off SDK init critical path #5904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -352,6 +352,8 @@ class SentryAndroidTest { | |
| @Config(sdk = [26]) | ||
| fun `init starts session replay if app is in foreground`() { | ||
| initSentryWithForegroundImportance(true) { _ -> | ||
| // replay start is posted to the main looper, so drain it before asserting | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like we should assert that isRecording() is false before draining the main looper b/c we don't want this test to continue to pass if we regress back to synchronous init. |
||
| Shadows.shadowOf(Looper.getMainLooper()).idle() | ||
| assertTrue(Sentry.getCurrentHub().options.replayController.isRecording()) | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replay start deferred past app onCreate
Medium Severity
Handler.postonly runs after the current main-looper message finishes. Auto-init runs insidehandleBindApplication, so that message also includesApplication.onCreate. Session Replay therefore starts only afterApplication.onCreate, and startup crashes there no longer get areplayIdor recording. Previouslystart()ran synchronously during init, beforeonCreatecontinued.Reviewed by Cursor Bugbot for commit 9495885. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this matters because session replays for startup crashes so early won't have anything visible anyways.