Skip to content

feat(attributes): Complete net.* aliases and transform net.transport - #588

Merged
JPeer264 merged 1 commit into
jp/conv-http-target-transformfrom
jp/conv-net-alias-fixes
Aug 28, 2026
Merged

feat(attributes): Complete net.* aliases and transform net.transport#588
JPeer264 merged 1 commit into
jp/conv-http-target-transformfrom
jp/conv-net-alias-fixes

Conversation

@JPeer264

@JPeer264 JPeer264 commented Aug 27, 2026

Copy link
Copy Markdown
Member

Following were missing:

  • net.peer.name replaces onto server.address but was not part of that alias group. It now joins it, like http.host, which is ambiguous between server and client in the same way.
  • net.sock.peer.port replaces onto network.peer.port and neither named the other. The equivalent host pair, net.sock.host.port and network.local.port, already does.
  • net.transport changes its values from ip_tcp and ip_udp to tcp and udp, so it needs a transformation rather than a plain rename. Adds net_transport_to_network_transport.

net.host.port and net.peer.port are left untouched. Both correctly replace onto server.port, while network.local.port and network.peer.port descend from the net.sock.* attributes, per the OpenTelemetry split.

Replaced by getsentry/sentry-javascript#23301

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Complete net.* aliases and transform net.transport by JPeer264 in #588
  • Name the replacements for the deprecated http.target by JPeer264 in #587
  • Add url.path.params.<key> (deprecated) in favor of url.path.parameter.<key> by JPeer264 in #586
  • Add graphql.source (deprecated) in favor of graphql.document by JPeer264 in #584
  • Add legacy Vercel AI span attributes (deprecated) by JPeer264 in #583
  • Add legacy AMQP and Redis span attributes (deprecated) by JPeer264 in #581
  • Add HTTP body size and status text attributes by msonnb in #574
  • Add graphql.processing.type by andreiborza in #572

Other

  • (span-names) Add url.domainrule for http.client spans by Lms24 in #575

Bug Fixes 🐛

Names

  • Add gen_ai.function_id and gen_ai.pipeline.name to agent span name templates by RulaKhaled in #593
  • Add missing gen_ai ops to span name rules by Lms24 in #579
  • Include tool name in gen_ai.execute_tool span names by Lms24 in #580
  • Correct graphql span name examples by andreiborza in #573

Internal Changes 🔧

  • (attributes) Add search alias for segment name by nsdeschenes in #577
  • (search-metadata) Add visibility field by nsdeschenes in #597

🤖 This preview updates automatically when you update the PR.

@JPeer264
JPeer264 force-pushed the jp/conv-net-alias-fixes branch from 62a0df9 to 6235967 Compare August 27, 2026 08:18
@JPeer264
JPeer264 marked this pull request as ready for review August 27, 2026 09:00
@JPeer264
JPeer264 requested review from a team, Lms24, cleptric, mjq and nsdeschenes as code owners August 27, 2026 09:00
@JPeer264
JPeer264 force-pushed the jp/conv-net-alias-fixes branch from 6235967 to 38ec07f Compare August 27, 2026 09:26

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to address the transformation. The other changes look good to me, thanks!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid the transformation here, my pragmatic take would be we just set status 'backfill' and live with the slight deviations. cc @mjq / @nsdeschenes is that alright with you?

Alternative would be status: null, which is probably also fine, given we don't seem to depend on the attributes in the frontend.

@JPeer264
JPeer264 force-pushed the jp/conv-net-alias-fixes branch from 38ec07f to 5dd767c Compare August 27, 2026 16:21
@JPeer264
JPeer264 force-pushed the jp/conv-net-alias-fixes branch from 5dd767c to 1afdfaf Compare August 27, 2026 16:30
@JPeer264
JPeer264 force-pushed the jp/conv-net-alias-fixes branch from 1afdfaf to 4393f68 Compare August 27, 2026 16:49
Comment thread model/attributes/net/net__peer__name.json
@JPeer264
JPeer264 force-pushed the jp/conv-net-alias-fixes branch from 4393f68 to 615dbd7 Compare August 27, 2026 17:29
@JPeer264
JPeer264 force-pushed the jp/conv-net-alias-fixes branch from 615dbd7 to 36a6454 Compare August 28, 2026 11:49
…transport`

`net.peer.name` replaces onto `server.address` and `net.sock.peer.port`
replaces onto `network.peer.port`, but neither pair named the other side.
Both alias groups are complete now.

`net.transport` changes its values on the replacement, from `ip_tcp` and
`ip_udp` to `tcp` and `udp`, so the old value cannot be copied over.
It moves from `_status: "backfill"` to `_status: null` and keeps
`network.transport` as the replacement.

Replaced by getsentry/sentry-javascript#23301

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@JPeer264
JPeer264 force-pushed the jp/conv-net-alias-fixes branch from 36a6454 to ac3bad2 Compare August 28, 2026 12:12
@JPeer264
JPeer264 merged commit 8c899d4 into main Aug 28, 2026
24 of 25 checks passed
@JPeer264
JPeer264 deleted the jp/conv-net-alias-fixes branch August 28, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants