feat(attributes): Complete net.* aliases and transform net.transport - #588
Merged
Merged
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛Names
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
JPeer264
force-pushed
the
jp/conv-net-alias-fixes
branch
from
August 27, 2026 08:18
62a0df9 to
6235967
Compare
JPeer264
marked this pull request as ready for review
August 27, 2026 09:00
JPeer264
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
August 27, 2026 09:00
JPeer264
force-pushed
the
jp/conv-net-alias-fixes
branch
from
August 27, 2026 09:26
6235967 to
38ec07f
Compare
Lms24
reviewed
Aug 27, 2026
Lms24
left a comment
Member
There was a problem hiding this comment.
We need to address the transformation. The other changes look good to me, thanks!
Member
There was a problem hiding this comment.
To avoid the transformation here, my pragmatic take would be we just set status 'backfill' and live with the slight deviations. cc @mjq / @nsdeschenes is that alright with you?
Alternative would be status: null, which is probably also fine, given we don't seem to depend on the attributes in the frontend.
JPeer264
force-pushed
the
jp/conv-net-alias-fixes
branch
from
August 27, 2026 16:21
38ec07f to
5dd767c
Compare
JPeer264
force-pushed
the
jp/conv-net-alias-fixes
branch
from
August 27, 2026 16:30
5dd767c to
1afdfaf
Compare
JPeer264
force-pushed
the
jp/conv-net-alias-fixes
branch
from
August 27, 2026 16:49
1afdfaf to
4393f68
Compare
JPeer264
force-pushed
the
jp/conv-net-alias-fixes
branch
from
August 27, 2026 17:29
4393f68 to
615dbd7
Compare
Lms24
approved these changes
Aug 28, 2026
JPeer264
force-pushed
the
jp/conv-net-alias-fixes
branch
from
August 28, 2026 11:49
615dbd7 to
36a6454
Compare
…transport` `net.peer.name` replaces onto `server.address` and `net.sock.peer.port` replaces onto `network.peer.port`, but neither pair named the other side. Both alias groups are complete now. `net.transport` changes its values on the replacement, from `ip_tcp` and `ip_udp` to `tcp` and `udp`, so the old value cannot be copied over. It moves from `_status: "backfill"` to `_status: null` and keeps `network.transport` as the replacement. Replaced by getsentry/sentry-javascript#23301 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/conv-net-alias-fixes
branch
from
August 28, 2026 12:12
36a6454 to
ac3bad2
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following were missing:
net.peer.namereplaces ontoserver.addressbut was not part of that alias group. It now joins it, likehttp.host, which is ambiguous between server and client in the same way.net.sock.peer.portreplaces ontonetwork.peer.portand neither named the other. The equivalent host pair,net.sock.host.portandnetwork.local.port, already does.net.transportchanges its values fromip_tcpandip_udptotcpandudp, so it needs a transformation rather than a plain rename. Addsnet_transport_to_network_transport.net.host.portandnet.peer.portare left untouched. Both correctly replace ontoserver.port, whilenetwork.local.portandnetwork.peer.portdescend from thenet.sock.*attributes, per the OpenTelemetry split.Replaced by getsentry/sentry-javascript#23301