feat(attributes): add search alias metadata#492
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
🤖 This preview updates automatically when you update the PR. |
| { | ||
| "public_alias": "span.op", | ||
| "internal_name": "sentry.op", | ||
| "search_type": "string", |
There was a problem hiding this comment.
Can likely make string the default, so not required.
| "internal_name": { | ||
| "description": "The internal attribute name used by the EAP search resolver", | ||
| "type": "string" | ||
| }, |
There was a problem hiding this comment.
Will this always duplicate the attribute's key? It feels like it ought to, in which case I'd prefer we make mismatches impossible by removing this property.
| "private": { | ||
| "description": "Whether the internal attribute should be hidden from public search results", | ||
| "type": "boolean" | ||
| }, |
There was a problem hiding this comment.
Is this already covered by visibility? cc @nsdeschenes
| "spans": { | ||
| "description": "The column expression in the indexed spans dataset", | ||
| "type": "string" | ||
| }, |
There was a problem hiding this comment.
This dataset has been removed. Only EAP exists now.
| "eap": { | ||
| "description": "The column expression in the Events Analytics Platform dataset", | ||
| "type": "string" | ||
| } |
There was a problem hiding this comment.
This seems better left to the Sentry backend to compute. (What's sent to EAP isn't a string either, so I don't think this is helpful here anyway). We do need a way to record when the search types and internal types of an attribute mismatch, though. I'd rather expose an (optional) internal_type property for this (one of string, boolean, double, integer, or array) so that the backend can construct the correct RPC proto.
| "description": "Whether the internal attribute should be hidden from public search results", | ||
| "type": "boolean" | ||
| }, | ||
| "dataset_mappings": { |
There was a problem hiding this comment.
Given the two other two comments re: spans and eap I think the whole dataset_mappings can be removed.
|
this closes #85 right? |
3 participants
No description provided.