Conversation
|
Thank you for your contribution! could you post some screenshots of CapacitorHttp being captured on sentry.io? |
|
Thank you for your contribution! I have a specific concern. |
|
Thank you for your contribution! |
|
Fixed them on commit 79cfd4d |
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
79cfd4d to
95aac25
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 95aac25. Configure here.
| onlyIfParent: !hasSpanStreamingEnabled(client), | ||
| attributes: { | ||
| 'http.request.method': method, | ||
| 'url.full': options.url, |
There was a problem hiding this comment.
Request params omitted from captured URLs
Medium Severity
Spans and breadcrumbs record only options.url, so CapacitorHttp params never appear in url.full or breadcrumb url. Native requests commonly send those values as the actual query string, so captured HTTP data does not match the request that was made.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 95aac25. Configure here.
| ### Features | ||
|
|
||
| - Add automatic instrumentation for `CapacitorHttp` requests, including spans, breadcrumbs, and trace propagation using `tracePropagationTargets` and `propagateTraceparent`. ([#1387](https://github.com/getsentry/sentry-capacitor/pull/1387)) | ||
| - |
There was a problem hiding this comment.
Could you move the code below above # 4.4.0 ?
| ### Features | |
| - Add automatic instrumentation for `CapacitorHttp` requests, including spans, breadcrumbs, and trace propagation using `tracePropagationTargets` and `propagateTraceparent`. ([#1387](https://github.com/getsentry/sentry-capacitor/pull/1387)) | |
| - | |
| ## Unreleased | |
| ### Features | |
| - Add automatic instrumentation for `CapacitorHttp` requests, including spans, breadcrumbs, and trace propagation using `tracePropagationTargets` and `propagateTraceparent`. ([#1387](https://github.com/getsentry/sentry-capacitor/pull/1387)) | |
| - |
|
Thanks for the PR! I tested it on an Android emulator (Capacitor 8, Duplicate spans when CapacitorHttp global patching is enabledWith A single
So one 1.6s request shows up as ~3.2s of HTTP time, is double-counted in Insights → Outbound API Requests, and adds two breadcrumbs. Trace headers are not duplicated (the inner call sees the existing To summarize the scope:
Suggestion: restrict the integration to direct plugin calls. For example, in the Known gap with that approach: URLs outside I haven't verified XHR (e.g. Angular Other
|


📢 Type of change
📜 Description
💡 Motivation and Context
Fixes Issue#820
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled