Skip to content

ci(release): Bump craft to 3.9.0 and update config - #338

Open
sentry-junior[bot] wants to merge 2 commits into
mainfrom
ci/bump-craft-3.9.0
Open

sentry-junior[bot] wants to merge 2 commits into
mainfrom
ci/bump-craft-3.9.0

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

This bumps the release workflow's pinned getsentry/craft action from 2.34.1 (3f2abdc5) to 3.9.0 (2e29b081).

Why: craft's "Check release blockers" step used to ask GitHub to cancel the run and then exit 0, so later steps kept going and could still open a getsentry/publish issue while a release-blocker issue was open (example run in getsentry/symbolic). getsentry/craft#956 fixed this in 3.9.0: the step now fails right away, and also fails if the blocker lookup errors. Same change as getsentry/symbolic#1134.

Compatibility with craft 3.x:

  • Action inputs only gained new optional ones between 2.x and 3.9.0, so the existing with: inputs need no changes.
  • None of the 3.0 breaking changes apply. .craft.yml doesn't set changelog.includePaths or unownedPaths, and it has no minVersion, so automatic version bumping stays off and craft runs the default scripts/bump-version.sh. There's no nuget target, so the 3.0 nuget change doesn't apply.
  • craft 3.9.0 prepare 99.0.0 --dry-run --no-push --no-changelog against current main loaded the config, ran scripts/bump-version.sh (it bumped pyproject.toml), and finished without errors. I ran --no-changelog because the sandbox's network proxy stalls on the large GitHub GraphQL response craft uses to build the changelog. That's a limitation of my environment, not a config problem, so the changelog step itself wasn't exercised.

There are no open release-blocker issues right now. Once this lands, an open one stops the release until it's closed or force is set.

Config changes

.craft.yml now targets craft 3.9.0. Release behavior stays the same:

  • Added minVersion: 3.9.0. Before, the file had no minVersion.
  • Added preReleaseCommand: bash scripts/bump-version.sh. Without a minVersion, craft fell back to scripts/bump-version.sh. At minVersion 2.21.0 or later it switches to automatic target bumping, so this keeps the script, which also updates the devservices== line in the README.
  • Added versioning.policy: manual, the old default below 2.14.0. Otherwise it would become auto.
  • Replaced the deprecated changelogPolicy: auto with changelog.policy: auto.

Dry run before and after: the same files get bumped (pyproject.toml, README.md), the deprecation warning is gone, and there are no errors.

via @BYK.

--

View Session in Sentry

Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c7d7b73. Configure here.

Comment thread .github/workflows/release.yml Resolved
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
@sentry-junior sentry-junior Bot changed the title ci(release): Bump getsentry/craft to 3.9.0 ci(release): Bump craft to 3.9.0 and update config Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant