Repository navigation
ci(release): Bump craft to 2.34.1 - #331
Merged
Merged
Conversation
The c6e2f04 (2.19.0) pin expands github.action_ref inside a composite run step, where it is always empty (actions/runner#2473). The action then falls back to an unauthenticated releases/latest API call, which 403s when the shared runner IP is rate limited. 2.34.1 passes the ref via env and resolves the SHA pin to its own release download. Co-Authored-By: Joshua Li <14209781+joshuarli@users.noreply.github.com>
joshuarli
approved these changes
Oct 14, 2026
This was referenced Oct 14, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow pinned
getsentry/craft@c6e2f04(2.19.0). That action version never actually resolved its own pin: it expands${{ github.action_ref }}inside a compositerun:step, where it is always empty (actions/runner#2473). So every release fell back to an unauthenticatedcurl https://api.github.com/repos/getsentry/craft/releases/latestand installed whatever the latest Craft was, not 2.19.0. When the shared runner IP runs out of anonymous API quota, that call 403s. That's how this release run failed (curl: (22) The requested URL returned error: 403).From 2.34.x onward (getsentry/craft#891), the action passes the ref through
env, resolves a SHA pin to the matching release, and downloadsgithub.com/getsentry/craft/releases/download/<version>/craftdirectly, with no anonymous API call. watto's release, on the same pin, logsDownloading Craft 2.34.1 from: https://github.com/getsentry/craft/releases/download/2.34.1/craft.The action inputs this workflow uses (
version,force) are unchanged in 2.34.1.cc @joshuarli
via @joshuarli.
--
View Junior Session [Sentry]