Repository navigation
fix(dependencies): Retry transient GitHub errors when downloading dependencies - #330
Merged
Merged
Conversation
…endencies GitHub's zipball API intermittently returns 5xx, which devservices never retried, failing devservices up (and sentry CI) on the first blip. Retry 5xx and 429 with exponential backoff, and include the underlying cause in the DependencyError message so failures are diagnosable. Co-Authored-By: Joshua Li <14209781+joshuarli@users.noreply.github.com>
joshuarli
approved these changes
Oct 14, 2026
This was referenced Oct 14, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #314 switched dependency fetching to GitHub zipball downloads,
_fetch_dependencyhas skipped retries for everyHTTPError. GitHub's API sometimes returns 5xx, so a single blip failsdevservices upright away. Because the cause is swallowed, all CI shows isDependencyError: sentry-shared-redis (...) on main.This recently blocked
getsentry-frontenddeploys. On 2026-10-14, between 16:07:01 and 16:07:11Z, about a dozen sentry CI runners gotHTTP Error 500from the zipball endpoint at the same time. One of them failedacceptance (0)on getsentry/sentry (job). The same issues also show sporadic 503s and 504s over the last month.Changes:
retry()gets an opt-inbackoffmultiplier; the default of1.0keeps current behavior for other callers.DependencyErrornow includes its cause, for example... on main (HTTPError: HTTP Error 500: Internal Server Error), so the real failure shows up in CI logs. This also changes the Sentry event message for this error.Fixes #182
Fixes DEVSERVICES-EE
Fixes DEVSERVICES-E5
Fixes DEVSERVICES-FK
Sentry issues:
via @joshuarli.
--
View Junior Session [Sentry]