build: require C++17 for crashpad_client consumers - #160
Merged
Conversation
The Sentry-maintained CMake metadata for `crashpad_client` still advertised `cxx_std_14`, but the headers it installs and exposes use C++17 library types such as `std::optional` and `std::string_view`. That lets CMake consumers compile against those headers with an insufficient language standard. Update the exported usage requirement to `cxx_std_17` so the CMake build stays in sync with the upstream Crashpad source requirements. This does not raise sentry-native's effective Crashpad requirement: Crashpad already sets `CMAKE_CXX_STANDARD` to `17` with `CMAKE_CXX_STANDARD_REQUIRED` enabled, and sentry-native documents the Crashpad backend as requiring a C++17-compatible compiler.
mujacica
approved these changes
Jul 17, 2026
JoshuaMoelans
approved these changes
Jul 17, 2026
jpnurmi
added a commit
to getsentry/sentry-native
that referenced
this pull request
Jul 21, 2026
* fix(crashpad): wait reliably for dump uploads The crash dumping test enabled crashpad-wait-for-upload in #1728, but ReportPendingSync() could race Crashpad's background upload worker. The worker could consume the queued report first, allowing the synchronous caller to return while the report was still being uploaded and marked completed. Session recovery only considers completed Crashpad reports. On Windows, the recovery process could therefore start too early, miss the crashed session, and make the dumping test fail intermittently. Retrying the test in #1737 reduced the symptom without fixing the race. The stack-overflow variant did not wait for upload and was later given the same retry workaround in #1870. Update Crashpad to serialize pending-report processing so a synchronous upload waits for an active worker pass to finish. Enable crashpad-wait-for-upload for the stack-overflow case, remove both flaky markers, and remove the now-unused flaky import. The Crashpad update also includes getsentry/crashpad#160, which requires C++17 for crashpad_client consumers. * Update CHANGELOG.md * Bump crashpad * Update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought up at:
The Sentry-maintained CMake metadata for
crashpad_clientstill advertisedcxx_std_14, but the headers it installs and exposes use C++17 library types such asstd::optionalandstd::string_view. That lets CMake consumers compile against those headers with an insufficient language standard.Update the exported usage requirement to
cxx_std_17so the CMake build stays in sync with the upstream Crashpad source requirements. This does not raise sentry-native's effective Crashpad requirement:Crashpad already sets
CMAKE_CXX_STANDARDto17withCMAKE_CXX_STANDARD_REQUIREDenabled, andcrashpad/CMakeLists.txt
Lines 89 to 90 in 3680125
sentry-native documents the Crashpad backend as requiring a C++17-compatible compiler:
https://github.com/getsentry/sentry-native/blob/034e49d521574ad4f3a7d018ef733e5b8a3bbcb1/README.md?plain=1#L101