fix(event): correctly parse project/event-id in view command#1263
Open
sentry[bot] wants to merge 1 commit into
Open
fix(event): correctly parse project/event-id in view command#1263sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
|
Contributor
Codecov Results 📊❌ Patch coverage is 50.00%. Project has 5476 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.67% 81.67% —%
==========================================
Files 425 425 —
Lines 29868 29870 +2
Branches 19398 19402 +4
==========================================
+ Hits 24393 24394 +1
- Misses 5475 5476 +1
- Partials 2033 2034 +1Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
sentry event view <project>/<event-id>would fail with aContextError: Event ID is required.The root cause was that
parseSingleArginsrc/commands/event/view.tswas incorrectly delegating single-slash arguments likeproject/event-idtoparseSlashSeparatedArg. TheparseSlashSeparatedArgfunction, when encountering a single slash, assumes the format isorg/projectand that an event ID is missing, leading it to throw theContextError.The fix adds a specific check within
parseSingleArgfor theproject/event-idpattern (where the part after the slash is a valid hex event ID) before the delegation toparseSlashSeparatedArg. This ensures that such arguments are correctly parsed and handled, preventing the erroneousContextError.Fixes CLI-CG
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.