fix(shortcodes): give the map id the UniqueID helper#269
Merged
Conversation
The id was built from .Ordinal, which resets to 0 inside the example shortcode's embedded RenderString, so two maps in two example blocks collided. Use mod-utils' UniqueID helper (v6.5.0).
Contributor
Author
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mapshortcode built its id from.Ordinal, which resets to 0 inside theexampleshortcode's embeddedRenderString, so two maps in two{{< example >}}blocks collided onleaflet-map-0. It now uses mod-utils'UniqueIDhelper (leaflet-map-UID-<n>). The explicitidargument still overrides. Bumps the mod-utils pin to v6.5.0, which provides the helper.Part of an ecosystem-wide
.Ordinal→UniqueID migration; independent of the companion PRs.🤖 Generated with Claude Code